From: "Michael S. Tsirkin" <mst@redhat.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting
Date: Thu, 12 Jan 2017 22:05:20 +0200 [thread overview]
Message-ID: <20170112220500-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <fc5de032-a64b-b072-6e52-441b6a685ee3@cardoe.com>
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote:
> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote:
> > The virtio_queue_set_notification() nesting introduced for AioContext polling
> > raised an assertion with virtio-net (even in non-polling mode). Converting
> > virtio-net and virtio-crypto to use virtio_queue_set_notification() in a
> > nesting fashion would be invasive and isn't worth it.
> >
> > Patch 1 contains the revert to resolve the bug that Doug noticed.
> >
> > Patch 2 is a less efficient but safe alternative.
> >
> > Stefan Hajnoczi (2):
> > Revert "virtio: turn vq->notification into a nested counter"
> > virtio: disable notifications again after poll succeeded
> >
> > hw/virtio/virtio.c | 21 +++++++++------------
> > 1 file changed, 9 insertions(+), 12 deletions(-)
> >
>
> So I just gave this series a whirl and it fixes the assert but causes
> another issue for me. While iPXE is getting a DHCP address the screen
> immediately flashes over to the UEFI shell. Its like a timeout is
> getting hit and just dropping me to the shell.
>
> --
> Doug Goldstein
>
Is this just with UEFI or with seabios as well?
--
MST
next prev parent reply other threads:[~2017-01-12 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 11:46 [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting Stefan Hajnoczi
2017-01-12 11:46 ` [Qemu-devel] [PATCH 1/2] Revert "virtio: turn vq->notification into a nested counter" Stefan Hajnoczi
2017-01-12 11:46 ` [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded Stefan Hajnoczi
2017-01-13 15:53 ` Michael S. Tsirkin
2017-01-12 16:57 ` [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting Doug Goldstein
2017-01-12 20:05 ` Michael S. Tsirkin [this message]
2017-01-13 14:48 ` Doug Goldstein
2017-01-13 12:02 ` Stefan Hajnoczi
2017-01-13 15:15 ` Doug Goldstein
2017-01-16 10:46 ` Stefan Hajnoczi
2017-01-16 21:03 ` Doug Goldstein
2017-01-17 3:09 ` Michael S. Tsirkin
2017-01-17 9:49 ` Stefan Hajnoczi
2017-01-14 3:48 ` Richard Henderson
2017-01-16 23:31 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112220500-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cardoe@cardoe.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.