From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet-rdma: Fix missing dma sync to nvme data structures
Date: Fri, 13 Jan 2017 08:44:20 +0100 [thread overview]
Message-ID: <20170113074420.GA25814@lst.de> (raw)
In-Reply-To: <1484261109-3316-1-git-send-email-parav@mellanox.com>
On Thu, Jan 12, 2017@04:45:09PM -0600, Parav Pandit wrote:
> This patch performs dma sync operations on nvme_commmand,
> inline page(s) and nvme_completion.
>
> nvme_command and write cmd inline data is synced
> (a) on receiving of the recv queue completion for cpu access.
> (b) before posting recv wqe back to rdma adapter for device access.
>
> nvme_completion is synced
> (a) on receiving send completion for nvme_completion for cpu access.
> (b) before posting send wqe to rdma adapter for device access.
>
> Pushing this patch through linux-rdma tree as its more relavant with
> Bart's changes for dma_map_ops of[1].
>
> [1] https://patchwork.kernel.org/patch/9514085/
This seems like a fix for 4.10-rc as the old code is buggy on
not DMA coherent architectures, so I suspect it should go in without
being based on Barts cleanup.
Btw, what architecture did you test this with? One of the not coherent
ARM SOCs?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: hch-jcswGhMUV9g@public.gmane.org,
sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] nvmet-rdma: Fix missing dma sync to nvme data structures
Date: Fri, 13 Jan 2017 08:44:20 +0100 [thread overview]
Message-ID: <20170113074420.GA25814@lst.de> (raw)
In-Reply-To: <1484261109-3316-1-git-send-email-parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jan 12, 2017 at 04:45:09PM -0600, Parav Pandit wrote:
> This patch performs dma sync operations on nvme_commmand,
> inline page(s) and nvme_completion.
>
> nvme_command and write cmd inline data is synced
> (a) on receiving of the recv queue completion for cpu access.
> (b) before posting recv wqe back to rdma adapter for device access.
>
> nvme_completion is synced
> (a) on receiving send completion for nvme_completion for cpu access.
> (b) before posting send wqe to rdma adapter for device access.
>
> Pushing this patch through linux-rdma tree as its more relavant with
> Bart's changes for dma_map_ops of[1].
>
> [1] https://patchwork.kernel.org/patch/9514085/
This seems like a fix for 4.10-rc as the old code is buggy on
not DMA coherent architectures, so I suspect it should go in without
being based on Barts cleanup.
Btw, what architecture did you test this with? One of the not coherent
ARM SOCs?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-13 7:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 22:45 [PATCH] nvmet-rdma: Fix missing dma sync to nvme data structures Parav Pandit
2017-01-12 22:45 ` Parav Pandit
2017-01-13 7:44 ` Christoph Hellwig [this message]
2017-01-13 7:44 ` Christoph Hellwig
2017-01-13 15:08 ` Parav Pandit
2017-01-13 15:08 ` Parav Pandit
2017-01-13 19:42 ` Sagi Grimberg
2017-01-13 19:42 ` Sagi Grimberg
2017-01-13 19:50 ` Parav Pandit
2017-01-13 19:50 ` Parav Pandit
2017-01-13 20:01 ` Sagi Grimberg
2017-01-13 20:01 ` Sagi Grimberg
2017-01-14 16:12 ` Parav Pandit
2017-01-14 16:12 ` Parav Pandit
2017-01-14 21:00 ` Sagi Grimberg
2017-01-14 21:00 ` Sagi Grimberg
2017-01-14 16:18 ` Christoph Hellwig
2017-01-14 16:18 ` Christoph Hellwig
2017-01-14 21:04 ` Sagi Grimberg
2017-01-14 21:04 ` Sagi Grimberg
2017-01-13 19:35 ` Sagi Grimberg
2017-01-13 19:35 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2017-01-14 16:45 Parav Pandit
2017-01-14 16:45 ` Parav Pandit
2017-01-14 21:07 ` Sagi Grimberg
2017-01-14 21:07 ` Sagi Grimberg
2017-01-16 15:31 ` Christoph Hellwig
2017-01-16 15:31 ` Christoph Hellwig
2017-01-16 17:18 ` Parav Pandit
2017-01-16 17:18 ` Parav Pandit
2017-01-16 17:30 ` Christoph Hellwig
2017-01-16 17:30 ` Christoph Hellwig
2017-01-12 22:42 Parav Pandit
2017-01-12 22:42 ` Parav Pandit
2017-01-12 22:45 ` Parav Pandit
2017-01-12 22:45 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113074420.GA25814@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.