From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk. [2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gmr-mx.google.com with ESMTPS id 133si175032wmj.1.2017.01.13.07.52.50 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 13 Jan 2017 07:52:50 -0800 (PST) Date: Fri, 13 Jan 2017 15:52:29 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Alexandre Belloni , Alessandro Zummo , Amelie Delaunay , Alexandre Torgue , Mathieu Poirier , linux-kernel@vger.kernel.org, Mark Brown , Maxime Coquelin , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: [rtc-linux] Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> References: <20170113153311.2611510-1-arnd@arndb.de> <20170113153311.2611510-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de> Sender: Russell King - ARM Linux Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote: > -#define PWR_CR_DBP BIT(8) > +#define PWR_CR_DBP (u32)BIT(8) Shouldn't that have parens around it as it's no longer a simple expression. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Fri, 13 Jan 2017 15:52:29 +0000 Subject: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de> References: <20170113153311.2611510-1-arnd@arndb.de> <20170113153311.2611510-3-arnd@arndb.de> Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote: > -#define PWR_CR_DBP BIT(8) > +#define PWR_CR_DBP (u32)BIT(8) Shouldn't that have parens around it as it's no longer a simple expression. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdAMPws (ORCPT ); Fri, 13 Jan 2017 10:52:48 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:47730 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbdAMPwr (ORCPT ); Fri, 13 Jan 2017 10:52:47 -0500 Date: Fri, 13 Jan 2017 15:52:29 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Alexandre Belloni , Alessandro Zummo , Amelie Delaunay , Alexandre Torgue , Mathieu Poirier , linux-kernel@vger.kernel.org, Mark Brown , Maxime Coquelin , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> References: <20170113153311.2611510-1-arnd@arndb.de> <20170113153311.2611510-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote: > -#define PWR_CR_DBP BIT(8) > +#define PWR_CR_DBP (u32)BIT(8) Shouldn't that have parens around it as it's no longer a simple expression. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.