Re: [PATCH v5] mbuf: add a function to linearize a packet

[Olivier Matz <olivier.matz@6wind.com>]

On Thu, 12 Jan 2017 10:40:44 +0100, Tomasz Kulasek
<tomaszx.kulasek@intel.com> wrote:
> This patch adds function rte_pktmbuf_linearize to let crypto PMD
> coalesce chained mbuf before crypto operation and extend their
> capabilities to support segmented mbufs when device cannot handle
> them natively.
> 
> Included unit tests for rte_pktmbuf_linearize functionality:
> 
>  1) Creates banch of segmented mbufs with different size and number of
>     segments.
>  2) Fills noncontigouos mbuf with sequential values.
>  3) Uses rte_pktmbuf_linearize to coalesce segmented buffer into one
>     contiguous.
>  4) Verifies data in linearized buffer.
> 
> Dependencies:
> 
> This patch is rebased to the dpdk-next-crypto and should be applied
> before "Chained Mbufs support in SW PMDs" patchset.
> 
> changes in v5:
>  - name of patch changed,
>  - improved coding style,
> 
> changes in v4:
>  - separated from "Chained Mbufs support in SW PMDs" patch set for
>    better reviewing,
>  - merged "rte_pktmbuf_linearize" implementation with unit tests,
> 
> changes in v3:
>  - rebased to dpdk-next-crypto
> 
> changes in v2:
>  - rte_pktmbuf_coalesce replaced with rte_pktmbuf_linearize
> 
> Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Cc: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Just one comment about the changelog for next time: as it's not
something we need to keep in the git history, you can put it after the
'---', so it will be dropped when applying the patch with 'git am'.

Thanks,
Olivier