All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, rogerq@ti.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: OMAP5 / DRA7: indicate that SATA port 0 is available.
Date: Fri, 13 Jan 2017 09:19:37 -0800	[thread overview]
Message-ID: <20170113171936.GA2630@atomide.com> (raw)
In-Reply-To: <423304d1-ffe3-ce7e-74d9-9707c391d501@ti.com>

* Jean-Jacques Hiblot <jjhiblot@ti.com> [170113 00:00]:
> 
> 
> On 12/01/2017 23:36, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [170112 14:31]:
> > > * Jean-Jacques Hiblot <jjhiblot@ti.com> [170109 04:23]:
> > > > AHCI provides the register PORTS_IMPL to let the software know which port
> > > > is supported. The register must be initialized by the bootloader. However
> > > > in some cases u-boot doesn't properly initialize this value (if it is not
> > > > compiled with SATA support for example or if the SATA initialization fails).
> > > > The DTS entry "ports-implemented" can be used to override the value in
> > > > PORTS_IMPL.
> > > > Adding this entry in the dts allows us no to worry about what is done by
> > > > the bootloader.
> > > Adding into omap-for-v4.11/dt thanks.
> > Actually not applying just yet as I just noticed you tagged this for stable.
> > 
> > Care to describe what breaks and on which devices without this patch?
> Hi tony,
> 
> Without this patch the SATA will not work in the following two cases:
> * if there has been a failure to initialize SATA in u-boot.
> * if ahci_platform module has been removed and re-inserted. The reason is
> that the content of PORTS_IMPL is lost after the module is removed. I
> suspect that it's because the controller is reset by the hwmod.

OK I'll add that to the comments and apply into omap-for-v4.10/fixes.

Thanks,

Tony

      reply	other threads:[~2017-01-13 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 12:22 [PATCH] ARM: dts: OMAP5 / DRA7: indicate that SATA port 0 is available Jean-Jacques Hiblot
2017-01-09 12:22 ` Jean-Jacques Hiblot
2017-01-12 22:30 ` Tony Lindgren
     [not found]   ` <20170112223007.GP2630-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-12 22:36     ` Tony Lindgren
2017-01-12 22:36       ` Tony Lindgren
2017-01-13  7:59       ` Jean-Jacques Hiblot
2017-01-13  7:59         ` Jean-Jacques Hiblot
2017-01-13 17:19         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113171936.GA2630@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jjhiblot@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.