All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yannick Brosseau <scientist@fb.com>
Cc: namhyung@kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com, mbd@fb.com
Subject: Re: [PATCH] perf script: Also allow forcing reading of non-root owned files by root
Date: Fri, 13 Jan 2017 16:24:40 -0300	[thread overview]
Message-ID: <20170113192440.GC32549@kernel.org> (raw)
In-Reply-To: <20170113182527.18625-1-scientist@fb.com>

Em Fri, Jan 13, 2017 at 01:25:27PM -0500, Yannick Brosseau escreveu:
> In 2059fc7a5a9e6677, perf report was added the option of forcing reading
> of non-root owned symbol file.
> 
> This add the same behavior for perf script.

looks ok, applied.

- Arnaldo
 
> Reported-by: Mark Drayton <mbd@fb.com>
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
>  tools/perf/builtin-script.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 2f3ff69fc4e7..c0783b4f7b6c 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2180,7 +2180,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
>  		    "Show the mmap events"),
>  	OPT_BOOLEAN('\0', "show-switch-events", &script.show_switch_events,
>  		    "Show context switch events (if recorded)"),
> -	OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"),
> +	OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
>  	OPT_BOOLEAN(0, "ns", &nanosecs,
>  		    "Use 9 decimal places when displaying time"),
>  	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
> @@ -2212,6 +2212,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
>  			     PARSE_OPT_STOP_AT_NON_OPTION);
>  
>  	file.path = input_name;
> +	file.force = symbol_conf.force;
>  
>  	if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
>  		rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
> -- 
> 2.11.0

  reply	other threads:[~2017-01-13 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 18:25 [PATCH] perf script: Also allow forcing reading of non-root owned files by root Yannick Brosseau
2017-01-13 19:24 ` Arnaldo Carvalho de Melo [this message]
2017-01-18  9:21 ` [tip:perf/core] " tip-bot for Yannick Brosseau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113192440.GC32549@kernel.org \
    --to=acme@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbd@fb.com \
    --cc=namhyung@kernel.org \
    --cc=scientist@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.