From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RESEND v2] at91: video: Support driver-model for the HLCD driver
Date: Fri, 13 Jan 2017 20:17:18 +0100 [thread overview]
Message-ID: <20170113201718.169b0473@crub> (raw)
In-Reply-To: <20170111023648.25874-1-songjun.wu@microchip.com>
Hi,
On Wed, 11 Jan 2017 10:36:48 +0800
Songjun Wu songjun.wu at microchip.com wrote:
> Add driver-model support to this driver.
>
> Signed-off-by: Songjun Wu <songjun.wu@microchip.com>
> ---
>
> Changes in v2:
> - Due to the peripheral clock driver improvement, remove
> the unneccessary clock calling.
>
> drivers/video/Kconfig | 7 +
> drivers/video/Makefile | 2 +-
> drivers/video/atmel_hlcdfb.c | 314 ++++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 319 insertions(+), 4 deletions(-)
there are many issues with this patch. First it needs re-basing to apply
on current master branch. The U-Boot image linking fails with this patch
applied. You change CONFIG_ATMEL_HLCD to CONFIG_VIDEO_ATMEL_HLCD, but
no board config files in include/config are updated accordingly.
If I update for this option e.g. in at91sam9x5ek.h, the driver doesn't
build. The building also doesn't work when I enable DM support.
Please fix all these issues before resubmitting. Thanks.
--
Anatolij
next prev parent reply other threads:[~2017-01-13 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 2:36 [U-Boot] [PATCH RESEND v2] at91: video: Support driver-model for the HLCD driver Songjun Wu
2017-01-13 19:17 ` Anatolij Gustschin [this message]
2017-01-16 2:44 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113201718.169b0473@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.