From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: eguan@redhat.com, Chaitanya.Kulkarni@wdc.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: don't try to discard from __blkdev_issue_zeroout
Date: Fri, 13 Jan 2017 15:18:29 -0700 [thread overview]
Message-ID: <20170113221829.GB16425@kernel.dk> (raw)
In-Reply-To: <1484316977-2474-1-git-send-email-hch@lst.de>
On Fri, Jan 13 2017, Christoph Hellwig wrote:
> Discard can return -EIO asynchronously if the alignment for the request
> isn't suitable for the driver, which makes a proper fallback to other
> methods in __blkdev_issue_zeroout impossible. Thus only issue a sync
> discard from blkdev_issue_zeroout an don't try discard at all from
> __blkdev_issue_zeroout as a non-invasive workaround.
>
> One more reason why abusing discard for zeroing must die..
Added for 4.10, thanks.
--
Jens Axboe
prev parent reply other threads:[~2017-01-13 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 14:16 [PATCH] block: don't try to discard from __blkdev_issue_zeroout Christoph Hellwig
2017-01-13 22:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113221829.GB16425@kernel.dk \
--to=axboe@kernel.dk \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=eguan@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.