From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdANShu (ORCPT ); Sat, 14 Jan 2017 13:37:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41110 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdANSht (ORCPT ); Sat, 14 Jan 2017 13:37:49 -0500 Date: Sat, 14 Jan 2017 19:38:01 +0100 From: Greg KH To: Kartikey Singh Cc: insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro Message-ID: <20170114183801.GA27644@kroah.com> References: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > do while loop removed from single statement macro > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/wifi.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h > index 9e08e68..57db709 100644 > --- a/drivers/staging/rtl8188eu/include/wifi.h > +++ b/drivers/staging/rtl8188eu/include/wifi.h > @@ -481,9 +481,7 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe) > ------------------------------------------------------------------------------*/ > > #define SetOrderBit(pbuf) \ > - do { \ > - *(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_); \ > - } while (0) > + (*(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_)) This macro is never used, so it could just be removed, right? > #define GetOrderBit(pbuf) \ > (((*(unsigned short *)(pbuf)) & le16_to_cpu(_ORDER_)) != 0) Same with that one. Care to do that type of fixup instead please? thanks, greg k-h