From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdANTkZ (ORCPT ); Sat, 14 Jan 2017 14:40:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43124 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbdANTkY (ORCPT ); Sat, 14 Jan 2017 14:40:24 -0500 Date: Sat, 14 Jan 2017 20:40:36 +0100 From: Greg KH To: Kartikey singh Cc: Ivan Safonov , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro Message-ID: <20170114194036.GB30750@kroah.com> References: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook> <20170114183801.GA27644@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > I think that macro is required. Anyway I won't have trouble cleaning it up if > you say so. I don't see it being used anywhere, do you? Use 'git grep' to search for it. Even better yet, remove it and rebuild the driver and see if it breaks :) thanks, greg k-h