From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751079AbdAOK4U (ORCPT ); Sun, 15 Jan 2017 05:56:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54754 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdAOK4T (ORCPT ); Sun, 15 Jan 2017 05:56:19 -0500 Date: Sun, 15 Jan 2017 11:56:32 +0100 From: Greg KH To: Ivan Safonov Cc: Kartikey singh , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro Message-ID: <20170115105632.GB26374@kroah.com> References: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook> <20170114183801.GA27644@kroah.com> <20170114194036.GB30750@kroah.com> <3aae100e-7a1b-fbc7-4711-cc7b46edf02d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3aae100e-7a1b-fbc7-4711-cc7b46edf02d@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2017 at 10:53:04PM +0300, Ivan Safonov wrote: > On 01/14/2017 10:40 PM, Greg KH wrote: > > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > > Even better yet, remove it and rebuild the driver and see if it > > breaks :) > > Only if the code is not between #ifn?def / #endif... Heh, fair enough, but it usually is a good sign if you do a build, along with a search, that you are safe to remove something. thanks, greg k-h