Re: [Qemu-devel] [PATCH v3 2/2] memory: hmp: add "-f" for "info mtree"

[Peter Xu <peterx@redhat.com>]

On Fri, Jan 13, 2017 at 06:19:10PM +0000, Dr. David Alan Gilbert wrote:

[...]

> > -void mtree_info(fprintf_function mon_printf, void *f)
> > +static void mtree_print_flatview(fprintf_function p, void *f,
> > +                                 AddressSpace *as)
> > +{
> > +    FlatView *view = address_space_get_flatview(as);
> > +    FlatRange *range = &view->ranges[0];
> > +    MemoryRegion *mr;
> > +    int n = view->nr;
> > +
> > +    if (n <= 0) {
> > +        p(f, MTREE_INDENT "No rendered FlatView for "
> > +          "address space '%s'\n", as->name);
> 
> Do you need an unref there?

Definitely. Thanks!

-- peterx