From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cT1P9-0001kd-BV for qemu-devel@nongnu.org; Mon, 16 Jan 2017 02:08:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cT1P6-0005uh-5x for qemu-devel@nongnu.org; Mon, 16 Jan 2017 02:08:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cT1P5-0005uO-Tr for qemu-devel@nongnu.org; Mon, 16 Jan 2017 02:08:32 -0500 Date: Mon, 16 Jan 2017 15:08:26 +0800 From: Peter Xu Message-ID: <20170116070826.GB30108@pxdev.xzpeter.org> References: <1484276800-26814-1-git-send-email-peterx@redhat.com> <1484276800-26814-10-git-send-email-peterx@redhat.com> <11241cc6-139e-ee8f-ff54-e1ab83ecf45d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <11241cc6-139e-ee8f-ff54-e1ab83ecf45d@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC v3 09/14] memory: introduce memory_region_notify_one() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: qemu-devel@nongnu.org, tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, alex.williamson@redhat.com, bd.aviv@gmail.com On Fri, Jan 13, 2017 at 03:58:59PM +0800, Jason Wang wrote: >=20 >=20 > On 2017=E5=B9=B401=E6=9C=8813=E6=97=A5 11:06, Peter Xu wrote: > >Generalizing the notify logic in memory_region_notify_iommu() into a > >single function. This can be further used in customized replay() > >functions for IOMMUs. > > > >Signed-off-by: Peter Xu > >--- > > include/exec/memory.h | 15 +++++++++++++++ > > memory.c | 29 ++++++++++++++++++----------- > > 2 files changed, 33 insertions(+), 11 deletions(-) > > > >diff --git a/include/exec/memory.h b/include/exec/memory.h > >index 2233f99..f367e54 100644 > >--- a/include/exec/memory.h > >+++ b/include/exec/memory.h > >@@ -669,6 +669,21 @@ void memory_region_notify_iommu(MemoryRegion *mr, > > IOMMUTLBEntry entry); > > /** > >+ * memory_region_notify_one: notify a change in an IOMMU translation > >+ * entry to a single notifier > >+ * > >+ * This works just like memory_region_notify_iommu(), but it only > >+ * notifies a specific notifier, not all of them. > >+ * > >+ * @notifier: the notifier to be notified > >+ * @entry: the new entry in the IOMMU translation table. The entry > >+ * replaces all old entries for the same virtual I/O address = range. > >+ * Deleted entries have .@perm =3D=3D 0. > >+ */ > >+void memory_region_notify_one(IOMMUNotifier *notifier, > >+ IOMMUTLBEntry *entry); > >+ > >+/** > > * memory_region_register_iommu_notifier: register a notifier for ch= anges to > > * IOMMU translation entries. > > * > >diff --git a/memory.c b/memory.c > >index df62bd1..6e4c872 100644 > >--- a/memory.c > >+++ b/memory.c > >@@ -1665,26 +1665,33 @@ void memory_region_unregister_iommu_notifier(M= emoryRegion *mr, > > memory_region_update_iommu_notify_flags(mr); > > } > >-void memory_region_notify_iommu(MemoryRegion *mr, > >- IOMMUTLBEntry entry) > >+void memory_region_notify_one(IOMMUNotifier *notifier, > >+ IOMMUTLBEntry *entry) > > { > >- IOMMUNotifier *iommu_notifier; > > IOMMUNotifierFlag request_flags; > >- assert(memory_region_is_iommu(mr)); > >- > >- if (entry.perm & IOMMU_RW) { > >+ if (entry->perm & IOMMU_RW) { > > request_flags =3D IOMMU_NOTIFIER_MAP; > > } else { > > request_flags =3D IOMMU_NOTIFIER_UNMAP; > > } >=20 > Nit: you can keep this outside the loop. Yes, but this function is used in vtd_replay_hook() as well in latter patch. If I keep the above outside loop (IIUC you mean the loop in memory_region_notify_iommu()), I'll need to set it up as well in future vtd_replay_hook(), then that'll be slightly awkward. Considering that the notification will only happen at mapping changes, I'll prefer to keep the interface cleaner like what this patch has done. Thanks, -- peterx