From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v3 2/2] tpm: enhance TPM 2.0 PCR extend to support multiple banks Date: Mon, 16 Jan 2017 11:41:05 +0200 Message-ID: <20170116094105.k2vuf3cclippkbye@intel.com> References: <1484240290-4306-1-git-send-email-nayna@linux.vnet.ibm.com> <1484240290-4306-3-git-send-email-nayna@linux.vnet.ibm.com> <20170112182044.hehe5d5fblecejwo@intel.com> <58787E47.3010908@linux.vnet.ibm.com> <20170113164315.kxbdhchoi64jy44p@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Ken Goldman Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Jan 13, 2017 at 03:19:59PM -0500, Ken Goldman wrote: > On 1/13/2017 11:43 AM, Jarkko Sakkinen wrote: > > >>>> +struct tpml_digest_values { > >>>> + u32 count; > >>>> + struct tpmt_ha digests[TPM2_ACTIVE_PCR_BANKS]; > >>>> +} __packed; > >>> > >>> Please remove this structure. > >> > >> Sorry Jarkko, I didn't understand this comment. > >> Why do we want to remove this structure. > > > > Well it is only used to pass two parameters. > > Might it be good in general to reuse TPM Part 2 > structures? For someone familiar with the TPM > spec, it could make reading the device driver code > easier. Having a structure to encapsulate two parameters is an overkill. /Jarkko ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi