From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net: ethernet: ti: davinci_cpdma: add set rate for a channel
Date: Mon, 16 Jan 2017 11:24:59 +0000 [thread overview]
Message-ID: <20170116112459.GA10004@mwanda> (raw)
Hello Ivan Khoronzhuk,
This is a semi-automatic email about new static checker warnings.
The patch 8f32b90981dc: "net: ethernet: ti: davinci_cpdma: add set
rate for a channel" from Nov 29, 2016, leads to the following Smatch
complaint:
drivers/net/ethernet/ti/davinci_cpdma.c:843 cpdma_chan_set_rate()
warn: variable dereferenced before check 'ch' (see line 838)
drivers/net/ethernet/ti/davinci_cpdma.c
837 {
838 struct cpdma_ctlr *ctlr = ch->ctlr;
^^^^
New NULL check?
839 unsigned long flags, ch_flags;
840 int ret, prio_mode;
841 u32 rmask;
842
843 if (!ch || !is_tx_chan(ch))
^^^
Too late.
844 return -EINVAL;
845
regards,
dan carpenter
reply other threads:[~2017-01-16 11:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116112459.GA10004@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.