Re: [PATCH] ARM: dts: r7s72100: fix sdhi clock define

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]


> > and then in the code do:
> >
> >         struct *cd_clk;
> >         cd_clk = devm_clk_get(&pdev->dev, "cd");
> >         if (cd_clk) {
> >                 clk_prepare_enable(cd_clk);
> >         }
> >
> >   (this simple 1-line fix patch is getting a lot more complicated)
> 
> Disclaimer: I don't know how/if the SDHI core manages clocks, and may
> interfere. Adding Wolfram.

Thanks for the heads up.

We have special callbacks for en-/disabling clocks:
sh_mobile_sdhi_clk_enable() and sh_mobile_sdhi_clk_disable().

I think those functions should get the above if-blocks (without curly
braces) to ensure we always have consistent 00 or 11 settings.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]