From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cT6t8-0002mo-Jl for qemu-devel@nongnu.org; Mon, 16 Jan 2017 07:59:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cT6t7-0007w5-KU for qemu-devel@nongnu.org; Mon, 16 Jan 2017 07:59:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34094) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cT6t7-0007vv-Er for qemu-devel@nongnu.org; Mon, 16 Jan 2017 07:59:53 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 763E58553D for ; Mon, 16 Jan 2017 12:59:53 +0000 (UTC) Date: Mon, 16 Jan 2017 12:59:47 +0000 From: "Daniel P. Berrange" Message-ID: <20170116125947.GJ13096@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170113131731.1246-1-pbonzini@redhat.com> <20170113131731.1246-6-pbonzini@redhat.com> <20170116113824.GD14226@lemon.Home> <20170116124728.GB10221@lemon.Home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170116124728.GB10221@lemon.Home> Subject: Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Paolo Bonzini , qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Jan 16, 2017 at 08:47:28PM +0800, Fam Zheng wrote: > On Mon, 01/16 13:24, Paolo Bonzini wrote: > > > > > > On 16/01/2017 12:38, Fam Zheng wrote: > > >> +void qio_channel_detach_aio_context(QIOChannel *ioc) > > >> +{ > > >> + ioc->read_coroutine = NULL; > > >> + ioc->write_coroutine = NULL; > > >> + qio_channel_set_aio_fd_handlers(ioc); > > >> + ioc->ctx = NULL; > > > > > > Why is qio_channel_set_aio_fd_handler not needed here? > > > > Because there are no read_coroutine and write_coroutine anymore. The > > caller needs to schedule them on the right AioContext after calling > > qio_channel_set_aio_context. See nbd_client_attach_aio_context in the > > next patch for an example. > > > > >> -tests/test-char$(EXESUF): tests/test-char.o qemu-char.o qemu-timer.o $(test-util-obj-y) $(qtest-obj-y) $(test-io-obj-y) > > >> +tests/test-char$(EXESUF): tests/test-char.o qemu-char.o qemu-timer.o $(test-util-obj-y) $(qtest-obj-y) $(test-io-obj-y) $(test-block-obj-y) > > > > > > I guess this is a hint for moving coroutine code into a lower level library like > > > util. > > > > Coroutine, or AioContext? The reason for this is that io/ now uses > > aio_co_wake. > > Or both. It just feels a bit odd to see *char* depend on *block*, maybe there're > more such dependencies to come even outside tests/? > > Not necessarily for this series, of course. On the contrary, I think it should be in this series - we shouldn't introduce a dependancy on the block layer from io layer. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|