From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf] netfilter: nf_tables: fix possible oops when dumping stateful objects
Date: Mon, 16 Jan 2017 14:26:53 +0100 [thread overview]
Message-ID: <20170116132653.GA20971@salvia> (raw)
In-Reply-To: <1483793510-30865-1-git-send-email-zlpnobody@163.com>
On Sat, Jan 07, 2017 at 08:51:50PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> When dumping nft stateful objects, if NFTA_OBJ_TABLE and NFTA_OBJ_TYPE
> attributes are not specified either, filter will become NULL, so oops
> will happen(actually nft utility will always set NFTA_OBJ_TABLE attr,
> so I write a test program to make this happen):
>
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: nf_tables_dump_obj+0x17c/0x330 [nf_tables]
> [...]
> Call Trace:
> ? nf_tables_dump_obj+0x5/0x330 [nf_tables]
> ? __kmalloc_reserve.isra.35+0x31/0x90
> ? __alloc_skb+0x5b/0x1e0
> netlink_dump+0x124/0x2a0
> __netlink_dump_start+0x161/0x190
> nf_tables_getobj+0xe8/0x280 [nf_tables]
Also applied, thanks.
prev parent reply other threads:[~2017-01-16 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 12:51 [PATCH nf] netfilter: nf_tables: fix possible oops when dumping stateful objects Liping Zhang
2017-01-16 13:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116132653.GA20971@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.