From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_cttimeout] Use __EXPORTED rather than EXPORT_SYMBOL
Date: Mon, 16 Jan 2017 14:30:34 +0100 [thread overview]
Message-ID: <20170116133034.GA31271@salvia> (raw)
In-Reply-To: <20170104223026.33362-1-cernekee@chromium.org>
On Wed, Jan 04, 2017 at 02:30:25PM -0800, Kevin Cernekee wrote:
> clang is sensitive to the ordering of
> __attribute__((visibility("default"))) relative to the function
> body. gcc is not. So if we try to re-declare an existing function
> with default visibility, clang prints a warning and generates
> a broken .so file in which nfct_timeout_* are not exported to library
> callers.
>
> Move the attribute up into the function definition to make clang happy.
Applied, thanks.
prev parent reply other threads:[~2017-01-16 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 22:30 [PATCH libnetfilter_cttimeout] Use __EXPORTED rather than EXPORT_SYMBOL Kevin Cernekee
2017-01-04 22:30 ` [PATCH libnetfilter_cthelper] " Kevin Cernekee
2017-01-16 13:30 ` Pablo Neira Ayuso
2017-01-16 13:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116133034.GA31271@salvia \
--to=pablo@netfilter.org \
--cc=cernekee@chromium.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.