From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: command emulation fix
Date: Mon, 16 Jan 2017 16:21:20 +0100 [thread overview]
Message-ID: <20170116152120.GA16072@lst.de> (raw)
In-Reply-To: <20170115230723.GB14446@mtj.duckdns.org>
On Sun, Jan 15, 2017 at 06:07:23PM -0500, Tejun Heo wrote:
> Ugh... I don't know. What we had previously is always guaranteed to
> work. I'm not really liking the fact that we're adding a possibility
> of failure here. Even if we do mempool, we would still have to
> protect it with a spinlock as mempool only guarantees one allocation
> at a time. Until we have a better solution, can we please revert back
> to where we were at least for the buffers needed from atomic context?
In that case you'll need to drop all but the first patch from the series
as ->queuecommand can always be called from atomic context.
next prev parent reply other threads:[~2017-01-16 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 16:50 command emulation fix Christoph Hellwig
2017-01-14 16:50 ` [PATCH] libata: switch allocations for command emulation to GFP_ATOMIC Christoph Hellwig
2017-01-15 23:07 ` command emulation fix Tejun Heo
2017-01-16 15:21 ` Christoph Hellwig [this message]
2017-01-18 19:17 ` Tejun Heo
2017-01-19 14:35 ` Christoph Hellwig
2017-01-19 20:23 ` Tejun Heo
2017-01-19 20:27 ` Christoph Hellwig
2017-01-19 20:34 ` Tejun Heo
2017-01-19 20:36 ` Tejun Heo
2017-01-19 20:41 ` Christoph Hellwig
2017-01-19 20:45 ` Tejun Heo
2017-01-19 20:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116152120.GA16072@lst.de \
--to=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.