From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750894AbdAPRXx (ORCPT ); Mon, 16 Jan 2017 12:23:53 -0500 Received: from mga09.intel.com ([134.134.136.24]:30840 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdAPRXv (ORCPT ); Mon, 16 Jan 2017 12:23:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="923145543" From: Andy Shevchenko To: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Andy Shevchenko , "Luis R . Rodriguez" Subject: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Date: Mon, 16 Jan 2017 19:23:45 +0200 Message-Id: <20170116172345.3823-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Legacy RTC requires interrupt line 8 to be dedicated for it. On Intel MID platforms the legacy PIC is absent and in order to make RTC work we need to allocate interrupt separately. Current solution brought by the commit 82a51c38f199 ("x86/platform/intel-mid: Enable RTC on Intel Merrifield") does it in a wrong place, and since it's done unconditionally for all x86 devices, some of them, e.g. PNP based, might get it wrong -- at the beginning x86_platform.legacy.rtc flag is set for all x86 devices. Move interrupt allocation to arch/x86/kernel/rtc.c module and allocate it for Intel MID platform devices only. Fixes: 82a51c38f199 ("x86/platform/intel-mid: Enable RTC on Intel Merrifield") Cc: Luis R. Rodriguez Signed-off-by: Andy Shevchenko --- - add headers and #ifdef to make kbuild bot happy - re-test on PNP platform with acpi=off, thus, update patch accordingly arch/x86/kernel/rtc.c | 21 +++++++++++++++++++++ arch/x86/platform/intel-mid/sfi.c | 14 -------------- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c index 5b21cb7d84d6..bf4cb88b9186 100644 --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -12,7 +12,9 @@ #include #include #include +#include #include +#include #include #ifdef CONFIG_X86_32 @@ -155,6 +157,20 @@ void read_persistent_clock(struct timespec *ts) x86_platform.get_wallclock(ts); } +#ifdef CONFIG_X86_IO_APIC +static __init int allocate_rtc_cmos_irq(void) +{ + struct irq_alloc_info info; + + if (!intel_mid_identify_cpu()) + return 0; + + ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0); + return mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info); +} +#else +static inline int allocate_rtc_cmos_irq(void) { return 0; } +#endif static struct resource rtc_resources[] = { [0] = { @@ -178,6 +194,7 @@ static struct platform_device rtc_device = { static __init int add_rtc_cmos(void) { + int ret; #ifdef CONFIG_PNP static const char * const ids[] __initconst = { "PNP0b00", "PNP0b01", "PNP0b02", }; @@ -197,6 +214,10 @@ static __init int add_rtc_cmos(void) if (!x86_platform.legacy.rtc) return -ENODEV; + ret = allocate_rtc_cmos_irq(); + if (ret < 0) + return ret; + platform_device_register(&rtc_device); dev_info(&rtc_device.dev, "registered platform RTC device (no PNP device found)\n"); diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c index e4d4cabbb370..19b43e3a9f0f 100644 --- a/arch/x86/platform/intel-mid/sfi.c +++ b/arch/x86/platform/intel-mid/sfi.c @@ -41,7 +41,6 @@ #include #include #include -#include #define SFI_SIG_OEM0 "OEM0" #define MAX_IPCDEVS 24 @@ -540,21 +539,8 @@ static int __init sfi_parse_devs(struct sfi_table_header *table) return 0; } -static int __init intel_mid_legacy_rtc_init(void) -{ - struct irq_alloc_info info; - - if (!x86_platform.legacy.rtc) - return -ENODEV; - - ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0); - return mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info); -} - static int __init intel_mid_platform_init(void) { - intel_mid_legacy_rtc_init(); - sfi_table_parse(SFI_SIG_GPIO, NULL, NULL, sfi_parse_gpio); sfi_table_parse(SFI_SIG_DEVS, NULL, NULL, sfi_parse_devs); return 0; -- 2.11.0