From: Olivier Matz <olivier.matz@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/virtio: fix advertised Rx offload capabilities
Date: Tue, 17 Jan 2017 11:33:45 +0100 [thread overview]
Message-ID: <20170117113345.75fc46f3@platinum> (raw)
In-Reply-To: <20170116061243.GK9770@yliu-dev.sh.intel.com>
On Mon, 16 Jan 2017 14:12:43 +0800, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:
> On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote:
> > When the virtio PMD is used on top of a vhost that does not support
> > offloads, Rx offload capabilities are still advertised by
> > virtio_dev_info_get(). But if an application tries to start the PMD
> > with Rx offloads enabled (rxmode.hw_ip_checksum = 1), the
> > initialization of the device will fail with -ENOTSUP and the
> > following log:
> >
> > rx ip checksum not available on this host
> >
> > This patch fixes the Rx offload capabilities returned by
> > virtio_dev_info_get() to be consistent with features advertised by
> > the host.
> >
> > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload")
> > Fixes: 86d59b21468a ("net/virtio: support LRO")
>
> Hi Olivier,
>
> This patch doesn't apply cleanly on top of next-virtio repo, would you
> midn to send v2, so that I can apply?
Sure, will do.
next prev parent reply other threads:[~2017-01-17 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 17:05 [PATCH] net/virtio: fix advertised Rx offload capabilities Olivier Matz
2017-01-16 6:12 ` Yuanhan Liu
2017-01-17 10:33 ` Olivier Matz [this message]
2017-01-17 10:35 ` [PATCH v2] " Olivier Matz
2017-01-17 11:08 ` Yuanhan Liu
2017-01-17 11:20 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117113345.75fc46f3@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.