From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:34740 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdAQL4F (ORCPT ); Tue, 17 Jan 2017 06:56:05 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: mwifiex: fix uninitialized variable access in pcie_remove From: Kalle Valo In-Reply-To: <20170113153534.2617372-1-arnd@arndb.de> References: <20170113153534.2617372-1-arnd@arndb.de> To: Arnd Bergmann Cc: Amitkumar Karwar , Arnd Bergmann , Nishant Sarmukadam , Brian Norris , Xinming Hu , Cathy Luo , Shengzhen Li , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20170117115537.021FE605A3@smtp.codeaurora.org> (sfid-20170117_125622_240675_6E3F0F98) Date: Tue, 17 Jan 2017 11:55:36 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann wrote: > Checking the firmware status from PCIe register only works > if the register is available, otherwise we end up with > random behavior: > > drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove': > drivers/net/wireless/marvell/mwifiex/pcie.c:585:5: error: 'fw_status' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This makes sure we treat the absence of the register as a failure. > > Fixes: 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag") > Signed-off-by: Arnd Bergmann Patch applied to wireless-drivers-next.git, thanks. 0e8edb9aed03 mwifiex: fix uninitialized variable access in pcie_remove -- https://patchwork.kernel.org/patch/9515899/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches