From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 20/29] net/ena: use eal I/O device memory
 read/write API
Date: Tue, 17 Jan 2017 20:00:28 +0530
Message-ID: <20170117143027.GA9201@localhost.localdomain>
References: <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484637244-7548-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484637244-7548-21-git-send-email-jerin.jacob@caviumnetworks.com>
 <CANw_3ZfwS1dMer3PcCnV3bnZbjww0w2eiAu1NithQ283WJPxPA@mail.gmail.com>
 <20170117141312.GA7844@localhost.localdomain>
 <CANw_3ZcaJW9_SyiKnXiVcL9xrzErXVMtUPwcRsdzoO7K+nC_=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>, <dev@dpdk.org>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>, Bruce Richardson <bruce.richardson@intel.com>,
 <jianbo.liu@linaro.org>, <viktorin@rehivetech.com>, Jakub Palider
 <jpa@semihalf.com>
To: Jan =?utf-8?Q?M=C4=99dala?= <jan@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0057.outbound.protection.outlook.com [104.47.41.57])
 by dpdk.org (Postfix) with ESMTP id 494F7106A
 for <dev@dpdk.org>; Tue, 17 Jan 2017 15:30:50 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CANw_3ZcaJW9_SyiKnXiVcL9xrzErXVMtUPwcRsdzoO7K+nC_=Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 17, 2017 at 03:27:39PM +0100, Jan Mędala wrote:
> Jerin,
> 
> Thanks for the very quick replay.
> 
> Actually I would like to keep *ena_com* untouched, as this layer suppose to
> be common between platforms. That's why it is better to leave definition in
> *ena_plat_dpdk.h*. Here is the patch that I would like to propose:

makes sense.I will add this change in v5.

> 
> diff --git a/drivers/net/ena/base/ena_plat_dpdk.h
> b/drivers/net/ena/base/ena_plat_dpdk.h
> index 87c3bf13..7eaebf40 100644
> --- a/drivers/net/ena/base/ena_plat_dpdk.h
> +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> @@ -44,6 +44,7 @@
>  #include <rte_atomic.h>
>  #include <rte_branch_prediction.h>
>  #include <rte_cycles.h>
> +#include <rte_io.h>
>  #include <rte_log.h>
>  #include <rte_malloc.h>
>  #include <rte_memzone.h>
> @@ -224,18 +225,8 @@ typedef uint64_t dma_addr_t;
>  #define ENA_MEM_ALLOC(dmadev, size) rte_zmalloc(NULL, size, 1)
>  #define ENA_MEM_FREE(dmadev, ptr) ({ENA_TOUCH(dmadev); rte_free(ptr); })
> 
> -static inline void writel(u32 value, volatile void  *addr)
> -{
> -       *(volatile u32 *)addr = value;
> -}
> -
> -static inline u32 readl(const volatile void *addr)
> -{
> -       return *(const volatile u32 *)addr;
> -}
> -
> -#define ENA_REG_WRITE32(value, reg) writel((value), (reg))
> -#define ENA_REG_READ32(reg) readl((reg))
> +#define ENA_REG_WRITE32(value, reg) rte_write32_relaxed((value), (reg))
> +#define ENA_REG_READ32(reg) rte_read32_relaxed((reg))
> 
>  #define ATOMIC32_INC(i32_ptr) rte_atomic32_inc(i32_ptr)
>  #define ATOMIC32_DEC(i32_ptr) rte_atomic32_dec(i32_ptr)
> 
> Cheers,
> Jan