From: Simon Horman <simon.horman@netronome.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@mellanox.com,
paulb@mellanox.com, john.fastabend@gmail.com, mrv@mojatatu.com,
hadarh@mellanox.com, ogerlitz@mellanox.com, roid@mellanox.com,
xiyou.wangcong@gmail.com, daniel@iogearbox.net
Subject: Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies
Date: Tue, 17 Jan 2017 15:59:04 +0100 [thread overview]
Message-ID: <20170117145903.GA17991@penelope.horms.nl> (raw)
In-Reply-To: <1484651509-27500-2-git-send-email-jhs@emojatatu.com>
On Tue, Jan 17, 2017 at 06:11:48AM -0500, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> Introduce optional 128-bit action cookie.
> Like all other cookie schemes in the networking world (eg in protocols
> like http or existing kernel fib protocol field, etc) the idea is to save
> user state that when retrieved serves as a correlator. The kernel
> _should not_ intepret it. The user can store whatever they wish in the
> 128 bits.
>
> Sample exercise(showing variable length use of cookie)
Hi Jamal,
I think that Daniel made some worthwhile comments regarding the
implementation but schematically I like what I see:
Reviewed-by: Simon Horman <simon.horman@netronome.com>
next prev parent reply other threads:[~2017-01-17 14:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 11:11 [PATCH net-next v4 0/2] Add support for tc cookies Jamal Hadi Salim
2017-01-17 11:11 ` [PATCH net-next v4 1/2] net sched actions: Add support for user cookies Jamal Hadi Salim
2017-01-17 12:03 ` Jiri Pirko
2017-01-17 14:16 ` Daniel Borkmann
2017-01-17 16:50 ` Jamal Hadi Salim
2017-01-17 16:53 ` Jamal Hadi Salim
2017-01-17 16:57 ` Daniel Borkmann
2017-01-17 17:03 ` Jamal Hadi Salim
2017-01-17 17:05 ` Jiri Pirko
2017-01-18 11:00 ` Jamal Hadi Salim
2017-01-17 14:59 ` Simon Horman [this message]
2017-01-17 18:40 ` Cong Wang
2017-01-18 11:35 ` Jamal Hadi Salim
2017-01-18 11:47 ` Paul Blakey
2017-01-18 12:13 ` Jamal Hadi Salim
2017-01-17 11:11 ` [PATCH net-next v4 2/2] net sched: Trivial whitespace and stylistic changes Jamal Hadi Salim
2017-01-17 12:12 ` Jiri Pirko
2017-01-17 16:30 ` Jamal Hadi Salim
2017-01-17 12:17 ` [PATCH net-next v4 0/2] Add support for tc cookies Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117145903.GA17991@penelope.horms.nl \
--to=simon.horman@netronome.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=john.fastabend@gmail.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.