All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	David Carrillo-Cisneros <davidcc@google.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 02/10] perf tools: Remove unneccessary feature-dwarf warning
Date: Tue, 17 Jan 2017 13:06:57 -0300	[thread overview]
Message-ID: <20170117160705.16055-3-acme@kernel.org> (raw)
In-Reply-To: <20170117160705.16055-1-acme@kernel.org>

From: David Carrillo-Cisneros <davidcc@google.com>

Don't warn for feature-dwarf==0 if user explicitily disabled DWARF by
using NO_DWARF=1.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20170112210159.76143-1-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.config | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 76c84f0eec52..03cf947755b9 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -291,8 +291,10 @@ else
       endif
     endif
     ifneq ($(feature-dwarf), 1)
-      msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
-      NO_DWARF := 1
+      ifndef NO_DWARF
+        msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
+        NO_DWARF := 1
+      endif
     else
       ifneq ($(feature-dwarf_getlocations), 1)
         msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157);
-- 
2.9.3

  parent reply	other threads:[~2017-01-17 16:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 16:06 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2017-01-17 16:06 ` [PATCH 01/10] perf pmu: Factor out scale conversion code Arnaldo Carvalho de Melo
2017-01-17 16:06 ` Arnaldo Carvalho de Melo [this message]
2017-01-17 16:06 ` [PATCH 03/10] tools lib subcmd: Fix missing member name Arnaldo Carvalho de Melo
2017-01-17 16:06 ` [PATCH 04/10] perf script: Fix man page about --dump-raw-trace option Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 05/10] perf script: Also allow forcing reading of non-root owned files by root Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 06/10] perf sched timehist: Account thread wait time separately Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 07/10] perf sched timehist: Add --state option Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 08/10] perf sched timehist: Show total wait times for summary Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 09/10] perf tools: Move two variables usied in libperf from perf.c Arnaldo Carvalho de Melo
2017-01-17 16:07 ` [PATCH 10/10] perf evlist: Fix typo in deliver_sample() Arnaldo Carvalho de Melo
2017-01-18  9:09 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117160705.16055-3-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.