From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH libdrm v2 2/4] xf86drm: Add USB support Date: Wed, 18 Jan 2017 09:56:25 +0100 Message-ID: <20170118085625.GD18989@ulmo.ba.sec> References: <20170112220429.28139-1-thierry.reding@gmail.com> <20170112220429.28139-3-thierry.reding@gmail.com> <201701131211.v0DCBVaA003863@glazunov.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1178307295==" Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F0096E7EE for ; Wed, 18 Jan 2017 08:56:29 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id r126so2382143wmr.3 for ; Wed, 18 Jan 2017 00:56:29 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: ML xorg-devel , ML dri-devel , Mark Kettenis List-Id: dri-devel@lists.freedesktop.org --===============1178307295== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x4pBfXISqBoDm8sr" Content-Disposition: inline --x4pBfXISqBoDm8sr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2017 at 02:38:39PM +0000, Emil Velikov wrote: > On 13 January 2017 at 12:11, Mark Kettenis wrot= e: > >> From: Thierry Reding > >> Date: Thu, 12 Jan 2017 23:04:27 +0100 > >> > >> Allow DRM/KMS devices hosted on USB to be detected by the drmDevice > >> infrastructure. > >> > >> v2: > >> - make sysfs_uevent_get() more flexible using a format string > >> > >> Signed-off-by: Thierry Reding > > > > All this sysfs parsing stuff is highly Linux-specific and should > > probably be #ifdef __linux__. Returning -EINVAL on non-Linux > > platforms for usb and host1x should be fine. > > > Nicely spotted. Thierry with the above the series is > Reviewed-by: Emil Velikov >=20 > Can you land these in the next few days - I would love to have a > libdrm release and use drmGetDevice[s]2 in mesa. Can do. I've thrown in another cleanup patch to reuse the new sysfs_uevent_get() function (now also #ifdef __linux__) for the Linux- specific PCI bus/device info. tests/drmdevice results are identical and valgrind doesn't flag any leaks. I'll send out the series once more just to be sure, but I think it should now be all fine. Thanks, Thierry --x4pBfXISqBoDm8sr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlh/LbYACgkQ3SOs138+ s6H4Mw/+JBju/iFZ35wHP2j+rb5/FkudubMTu3nixLs175xb2t9xHwhjTevU9jhH pjYYE+9YWbvw8WpwB0/GEJBuOQVQg8FffAmHbWTS+zDJWaledKad2ACkGooDMgAH /Jh/lir+28owRJJItJmeDqQS6NZnkPrYUNqVWdpJF1b9mUUSP1ZUNZ6FpepOf9sQ Y/4A8L7b3go76GZ6rsEBB9MNyjleHMTHwIU9smbFDNvVFNkVD4nhdVPm82u88eo2 szf5Sgk8xrDcw1JSJ/6cQ6VsXFFSY96qhk2I0Ssz88Y2KgZRGq/SiNzeTykcKhCR 0VyNrH4KQdkxG0TWOv5qjZjyoWn20byp3pPIuJ2uDkkKFsjFjVgidsCR7CcS7gXr PP+7+4VdL7mTRMkHsrjPkHc+dlynLpP11bLuTqlomPX77B573IwcQn++H9KsQcjJ grKqU1VVnJknMJi8cqxu9hRsgG99+Sst+2OrRcrMw7aVccWjZ0CRKWzJeNJd4kGV NfmUQjJkrKbh2f+/nyqaRbqnzDeJrwUZGyx94f8WwG3Mx6R/WJubq1rgCQehZeVh 6P8CN9Oxl/Sd3hBavO6tyYQFqrMNB94YYelWpnwpQuN3HVB57H20FV9urHGifPvk /6ESFhifPLQZP7JlW/6soz4JavFHW1rGuRM8i6eUkrhry2+eDRU= =hpgw -----END PGP SIGNATURE----- --x4pBfXISqBoDm8sr-- --===============1178307295== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1178307295==--