From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Clemens Gruber <clemens.gruber@pqgruber.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stable@vger.kernel.org,
Florian Vaussard <florian.vaussard@heig-vd.ch>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle
Date: Wed, 18 Jan 2017 13:09:48 +0200 [thread overview]
Message-ID: <20170118110948.GN2023@lahna.fi.intel.com> (raw)
In-Reply-To: <20170118105650.GL18989@ulmo.ba.sec>
On Wed, Jan 18, 2017 at 11:56:50AM +0100, Thierry Reding wrote:
> On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote:
> > When first implementing support for changing the output frequency, an
> > optimization was added to continue the PWM after changing the prescaler
> > without having to reprogram the ON and OFF registers for the duty cycle,
> > in case the duty cycle stayed the same.
> > This was flawed, because we compared the absolute value of the duty
> > cycle in nanoseconds instead of the ratio to the period.
> >
> > Fix the problem by removing the shortcut.
> >
> > Fixes: 01ec8472009c9 ("pwm-pca9685: Support changing the output frequency")
> > Cc: <stable@vger.kernel.org> # v4.3+
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > ---
> > drivers/pwm/pwm-pca9685.c | 11 -----------
> > 1 file changed, 11 deletions(-)
>
> Mika, Andy, can you guys help review this and 2/2?
Looks good to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-01-18 11:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 15:52 [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle Clemens Gruber
2016-12-13 15:52 ` [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber
2017-01-18 10:57 ` Thierry Reding
2017-01-18 11:09 ` Andy Shevchenko
2017-01-18 13:53 ` Clemens Gruber
2017-01-18 14:01 ` Andy Shevchenko
2017-01-18 14:25 ` Clemens Gruber
2017-01-19 12:34 ` Andy Shevchenko
2017-01-19 14:49 ` Clemens Gruber
2017-01-19 16:10 ` Andy Shevchenko
2017-01-19 16:52 ` Clemens Gruber
2017-01-19 16:58 ` Andy Shevchenko
2017-01-20 6:39 ` Thierry Reding
2017-01-20 9:58 ` Andy Shevchenko
2017-01-25 18:05 ` Clemens Gruber
2017-01-13 12:43 ` [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle Clemens Gruber
2017-01-18 10:56 ` Thierry Reding
2017-01-18 11:09 ` Mika Westerberg [this message]
2017-01-20 6:44 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118110948.GN2023@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clemens.gruber@pqgruber.com \
--cc=florian.vaussard@heig-vd.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.