From: Kalle Valo <kvalo@codeaurora.org>
To: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: linux-wireless@vger.kernel.org, johannes.berg@intel.com,
hofrat@osadl.org, xypron.glpk@gmx.de,
prameela.garnepudi@redpinesignals.com,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Subject: Re: [2/2] rsi: Device initialization sequence is changed
Date: Wed, 18 Jan 2017 11:46:44 +0000 (UTC) [thread overview]
Message-ID: <20170118114644.B0BC860805@smtp.codeaurora.org> (raw)
In-Reply-To: <1477044656-10402-1-git-send-email-prameela.j04cs@gmail.com>
Prameela Rani Garnepudi <prameela.j04cs@gmail.com> wrote:
> BT Co-ex support has been added in the firmware and hence BT, COEX queues are
> introducted. To support the latest firmware queues, packet processing,
> and initialization sequence is modified in the Host.
>
> Common device configuration parameters (tx command frame) need to be send after
> common card ready indication from the firmware. This frame contains information
> about the driver mode, coex mode, protocols to support etc. Once it is sent,
> then second level card ready indication comes for each protocol (WLAN, BT etc).
>
> Currently host supports only WLAN mode. New command frames are added as part
> of these changes.
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Few review comments:
* no C++ '//' style comments
* avoid magic numbers
* use structs for new firmware commands instead of cmd[offset] style
* struct rsi_ulp_gpio_vals, struct rsi_soc_gpio_vals and struct rsi_config_vals
don't look endian safe
--
https://patchwork.kernel.org/patch/9388627/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-01-18 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 10:10 [PATCH 2/2] rsi: Device initialization sequence is changed Prameela Rani Garnepudi
2017-01-18 11:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118114644.B0BC860805@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hofrat@osadl.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.garnepudi@redpinesignals.com \
--cc=prameela.j04cs@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.