From: Florian Westphal <fw@strlen.de>
To: thomas@habets.se
Cc: Florian Westphal <fw@strlen.de>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] iptables-save: Exit with error if unable to open proc file
Date: Wed, 18 Jan 2017 15:07:17 +0100 [thread overview]
Message-ID: <20170118140717.GF12001@breakpoint.cc> (raw)
In-Reply-To: <CA+kHd+db15eUCFb+_-T1zJVPSkogyLUTp2Fe-2u9z8B0E3a-_A@mail.gmail.com>
thomas@habets.se <thomas@habets.se> wrote:
> diff --git a/iptables/ip6tables-save.c b/iptables/ip6tables-save.c
> index f35e921..053413a 100644
> --- a/iptables/ip6tables-save.c
> +++ b/iptables/ip6tables-save.c
> @@ -35,10 +35,16 @@ static int for_each_table(int (*func)(const char
> *tablename))
Still a linewrap here, rest was fine so I fixed this up and applied
the patch, thanks!
I did not notce on 1st review but a 'Signed-off-by' line would be
good for future submissions.
next prev parent reply other threads:[~2017-01-18 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:58 [PATCH] iptables-save: Exit with error if unable to open proc file thomas
2017-01-18 14:07 ` Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-18 14:12 thomas
2017-01-18 13:23 Thomas Habets
2017-01-18 13:32 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118140717.GF12001@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thomas@habets.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.