All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dhananjay Balan <dhananjay@cliqz.com>
Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	stuart.yoder@nxp.com, linux-kernel@vger.kernel.org,
	joe@perches.com
Subject: Re: [PATCH v2] staging: fsl-mc: fix coding stye errors
Date: Wed, 18 Jan 2017 18:20:51 +0100	[thread overview]
Message-ID: <20170118172051.GD12664@kroah.com> (raw)
In-Reply-To: <1484736788-25038-1-git-send-email-dhananjay@cliqz.com>

On Wed, Jan 18, 2017 at 11:53:07AM +0100, Dhananjay Balan wrote:
> Split line at boolean operator.
> 
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
> 
> Signed-off-by: Dhananjay Balan <dhananjay@cliqz.com>
> ---
>  drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

What changed in v2?  That has to go below the --- line.  Please fix it
up and resend v3 with that information and read
Documentation/SubmittingPatches for all of the details about this.

thanks,

greg k-h

      parent reply	other threads:[~2017-01-18 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  8:11 [PATCH] staging: fsl-mc: fix coding stye errors Dhananjay Balan
2017-01-17  8:27 ` Dan Carpenter
2017-01-17  8:47   ` Joe Perches
2017-01-17 10:00     ` Dan Carpenter
2017-01-18 10:53       ` [PATCH v2] " Dhananjay Balan
2017-01-18 11:14         ` Greg KH
2017-01-18 17:20         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118172051.GD12664@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dhananjay@cliqz.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stuart.yoder@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.