From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2 1/2] drm: qxl: Open code probing sequence for qxl Date: Wed, 18 Jan 2017 17:01:12 -0200 Message-ID: <20170118190112.GP16017@joana> References: <20170117132603.4064-1-krisman@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-f195.google.com (mail-yb0-f195.google.com [209.85.213.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE9B26E8FF for ; Wed, 18 Jan 2017 19:01:18 +0000 (UTC) Received: by mail-yb0-f195.google.com with SMTP id w194so904241ybe.1 for ; Wed, 18 Jan 2017 11:01:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170117132603.4064-1-krisman@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gabriel Krisman Bertazi Cc: Daniel Vetter , Dave Airlie , dri-devel@lists.freedesktop.org, Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org SGkgR2FicmllbCwKCjIwMTctMDEtMTcgR2FicmllbCBLcmlzbWFuIEJlcnRhemkgPGtyaXNtYW5A Y29sbGFib3JhLmNvLnVrPjoKCj4gVGhpcyBhdm9pZHMgdXNpbmcgdGhlIGRlcHJlY2F0ZWQgZHJt X2dldF9wY2lfZGV2KCkgYW5kIGxvYWQoKSBob29rCj4gaW50ZXJmYWNlcyBpbiB0aGUgcXhsIGRy aXZlci4KPiAKPiBUaGUgb25seSB0cmlja3kgcGFydCBpcyB0byBlbnN1cmUgVFRNIGRlYnVnZnMg aW5pdGlhbGl6YXRpb24gaGFwcGVucwo+IGFmdGVyIHRoZSBkZWJ1Z2ZzIHJvb3Qgbm9kZSBpcyBj cmVhdGVkLCB3aGljaCBpcyBkb25lIGJ5IG1vdmluZyB0aGF0Cj4gY29kZSBpbnRvIHRoZSBkZWJ1 ZnNfaW5pdCgpIGhvb2suCj4gCj4gVGVzdGVkIG9uIHFlbXUgd2l0aCBpZ3QgYW5kIHJ1bm5pbmcg YSBXTSBvbiB0b3Agb2YgWC4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ICAtIERyb3AgdmVyaWZp Y2F0aW9uIGZvciBwcmltYXJ5IG1pbm9yIGluIHF4bF9kZWJ1Z3Nmc19pbml0Cj4gCj4gU2lnbmVk LW9mZi1ieTogR2FicmllbCBLcmlzbWFuIEJlcnRhemkgPGtyaXNtYW5AY29sbGFib3JhLmNvLnVr Pgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPgo+IENjOiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rh dm8ucGFkb3ZhbkBjb2xsYWJvcmEuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4 bF9kZWJ1Z2ZzLmMgfCAxMCArKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rydi5j ICAgICB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICBkcml2 ZXJzL2dwdS9kcm0vcXhsL3F4bF9kcnYuaCAgICAgfCAgNyArKysrLQo+ICBkcml2ZXJzL2dwdS9k cm0vcXhsL3F4bF9rbXMuYyAgICAgfCA0MCArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg ZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfdHRtLmMgICAgIHwgIDggKy0tLS0tCj4gIDUgZmlsZXMg Y2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKSwgNDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9x eGwvcXhsX2RlYnVnZnMuYwo+IGluZGV4IDI0MWFmOTEzMWRjOC4uMDU3YjJiNTQ3Y2FjIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9xeGwvcXhsX2RlYnVnZnMuYwo+IEBAIC04NCw4ICs4NCwxOCBAQCBpbnQKPiAg cXhsX2RlYnVnZnNfaW5pdChzdHJ1Y3QgZHJtX21pbm9yICptaW5vcikKPiAgewo+ICAjaWYgZGVm aW5lZChDT05GSUdfREVCVUdfRlMpCj4gKwlpbnQgcjsKPiArCXN0cnVjdCBxeGxfZGV2aWNlICpk ZXYgPQo+ICsJCShzdHJ1Y3QgcXhsX2RldmljZSAqKSBtaW5vci0+ZGV2LT5kZXZfcHJpdmF0ZTsK PiArCj4gIAlkcm1fZGVidWdmc19jcmVhdGVfZmlsZXMocXhsX2RlYnVnZnNfbGlzdCwgUVhMX0RF QlVHRlNfRU5UUklFUywKPiAgCQkJCSBtaW5vci0+ZGVidWdmc19yb290LCBtaW5vcik7Cj4gKwo+ ICsJciA9IHF4bF90dG1fZGVidWdmc19pbml0KGRldik7Cj4gKwlpZiAocikgewo+ICsJCURSTV9F UlJPUigiRmFpbGVkIHRvIGluaXQgVFRNIGRlYnVnZnNcbiIpOwo+ICsJCXJldHVybiByOwo+ICsJ fQo+ICAjZW5kaWYKPiAgCXJldHVybiAwOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9xeGwvcXhsX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZHJ2LmMKPiBpbmRl eCA0NjBiYmNlYWUyOTcuLjdjYzI5MDI3YTYxMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vcXhsL3F4bF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rydi5jCj4g QEAgLTYyLDEyICs2Miw2NyBAQCBzdGF0aWMgc3RydWN0IHBjaV9kcml2ZXIgcXhsX3BjaV9kcml2 ZXI7Cj4gIHN0YXRpYyBpbnQKPiAgcXhsX3BjaV9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwg Y29uc3Qgc3RydWN0IHBjaV9kZXZpY2VfaWQgKmVudCkKPiAgewo+ICsJc3RydWN0IGRybV9kZXZp Y2UgKmRybTsKPiArCXN0cnVjdCBxeGxfZGV2aWNlICpxZGV2Owo+ICsJaW50IHJldDsKPiArCj4g IAlpZiAocGRldi0+cmV2aXNpb24gPCA0KSB7Cj4gIAkJRFJNX0VSUk9SKCJxeGwgdG9vIG9sZCwg ZG9lc24ndCBzdXBwb3J0IGNsaWVudF9tb25pdG9yc19jb25maWcsIgo+ICAJCQkgICIgdXNlIHhm ODYtdmlkZW8tcXhsIGluIHVzZXIgbW9kZSIpOwo+ICAJCXJldHVybiAtRUlOVkFMOyAvKiBUT0RP OiBFTk9ERVYgPyAqLwo+ICAJfQo+IC0JcmV0dXJuIGRybV9nZXRfcGNpX2RldihwZGV2LCBlbnQs ICZxeGxfZHJpdmVyKTsKPiArCj4gKwlkcm0gPSBkcm1fZGV2X2FsbG9jKCZxeGxfZHJpdmVyLCAm cGRldi0+ZGV2KTsKPiArCWlmIChJU19FUlIoZHJtKSkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiAr Cj4gKwlxZGV2ID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IHF4bF9kZXZpY2UpLCBHRlBfS0VSTkVM KTsKPiArCWlmICghcWRldikgewo+ICsJCXJldCA9IC1FTk9NRU07Cj4gKwkJZ290byBmcmVlX2Ry bV9kZXZpY2U7Cj4gKwl9Cj4gKwo+ICsJcmV0ID0gcGNpX2VuYWJsZV9kZXZpY2UocGRldik7Cj4g KwlpZiAocmV0KQo+ICsJCWdvdG8gZnJlZV9kcm1fZGV2aWNlOwo+ICsKPiArCWRybS0+cGRldiA9 IHBkZXY7Cj4gKwlwY2lfc2V0X2RydmRhdGEocGRldiwgZHJtKTsKPiArCWRybS0+ZGV2X3ByaXZh dGUgPSBxZGV2Owo+ICsKPiArCXJldCA9IHF4bF9kZXZpY2VfaW5pdChxZGV2LCBkcm0sIHBkZXYs IGVudC0+ZHJpdmVyX2RhdGEpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIGRpc2FibGVfcGNpOwo+ ICsKPiArCXJldCA9IGRybV92YmxhbmtfaW5pdChkcm0sIDEpOwo+ICsJaWYgKHJldCkKPiArCQln b3RvIHVubG9hZDsKPiArCj4gKwlyZXQgPSBxeGxfbW9kZXNldF9pbml0KHFkZXYpOwo+ICsJaWYg KHJldCkKPiArCQlnb3RvIHZibGFua19jbGVhbnVwOwo+ICsKPiArCWRybV9rbXNfaGVscGVyX3Bv bGxfaW5pdChxZGV2LT5kZGV2KTsKPiArCj4gKwkvKiBDb21wbGV0ZSBpbml0aWFsaXphdGlvbi4g Ki8KPiArCXJldCA9IGRybV9kZXZfcmVnaXN0ZXIoZHJtLCBlbnQtPmRyaXZlcl9kYXRhKTsKPiAr CWlmIChyZXQpCj4gKwkJZ290byBtb2Rlc2V0X2NsZWFudXA7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4g Kwo+ICttb2Rlc2V0X2NsZWFudXA6Cj4gKwlxeGxfbW9kZXNldF9maW5pKHFkZXYpOwo+ICt2Ymxh bmtfY2xlYW51cDoKPiArCWRybV92YmxhbmtfY2xlYW51cChkcm0pOwo+ICt1bmxvYWQ6Cj4gKwlx eGxfZGV2aWNlX2ZpbmkocWRldik7Cj4gK2Rpc2FibGVfcGNpOgo+ICsJcGNpX2Rpc2FibGVfZGV2 aWNlKHBkZXYpOwo+ICtmcmVlX2RybV9kZXZpY2U6Cj4gKwlrZnJlZShxZGV2KTsKPiArCWtmcmVl KGRybSk7Cj4gKwlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IEBAIC0yMzAs NyArMjg1LDYgQEAgc3RhdGljIHN0cnVjdCBwY2lfZHJpdmVyIHF4bF9wY2lfZHJpdmVyID0gewo+ ICBzdGF0aWMgc3RydWN0IGRybV9kcml2ZXIgcXhsX2RyaXZlciA9IHsKPiAgCS5kcml2ZXJfZmVh dHVyZXMgPSBEUklWRVJfR0VNIHwgRFJJVkVSX01PREVTRVQgfCBEUklWRVJfUFJJTUUgfAo+ICAJ CQkgICBEUklWRVJfSEFWRV9JUlEgfCBEUklWRVJfSVJRX1NIQVJFRCwKPiAtCS5sb2FkID0gcXhs X2RyaXZlcl9sb2FkLAo+ICAJLnVubG9hZCA9IHF4bF9kcml2ZXJfdW5sb2FkLAo+ICAJLmdldF92 YmxhbmtfY291bnRlciA9IHF4bF9ub29wX2dldF92YmxhbmtfY291bnRlciwKPiAgCS5lbmFibGVf dmJsYW5rID0gcXhsX25vb3BfZW5hYmxlX3ZibGFuaywKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3F4bC9xeGxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kcnYuaAo+IGlu ZGV4IDg4M2Q4NjM5YzA0ZS4uZDBhZWQ5ZWQxMmQyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9xeGwvcXhsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZHJ2LmgK PiBAQCAtMzM2LDcgKzMzNiwxMCBAQCBfX3ByaW50ZigyLDMpIHZvaWQgcXhsX2lvX2xvZyhzdHJ1 Y3QgcXhsX2RldmljZSAqcWRldiwgY29uc3QgY2hhciAqZm10LCAuLi4pOwo+ICBleHRlcm4gY29u c3Qgc3RydWN0IGRybV9pb2N0bF9kZXNjIHF4bF9pb2N0bHNbXTsKPiAgZXh0ZXJuIGludCBxeGxf bWF4X2lvY3RsOwo+ICAKPiAtaW50IHF4bF9kcml2ZXJfbG9hZChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCB1bnNpZ25lZCBsb25nIGZsYWdzKTsKPiAraW50IHF4bF9kZXZpY2VfaW5pdChzdHJ1Y3Qg cXhsX2RldmljZSAqcWRldiwgc3RydWN0IGRybV9kZXZpY2UgKmRkZXYsCj4gKwkJICAgIHN0cnVj dCBwY2lfZGV2ICpwZGV2LCAgdW5zaWduZWQgbG9uZyBmbGFncyk7Cj4gK3ZvaWQgcXhsX2Rldmlj ZV9maW5pKHN0cnVjdCBxeGxfZGV2aWNlICpxZGV2KTsKPiArCj4gIHZvaWQgcXhsX2RyaXZlcl91 bmxvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIAo+ICBpbnQgcXhsX21vZGVzZXRfaW5p dChzdHJ1Y3QgcXhsX2RldmljZSAqcWRldik7Cj4gQEAgLTM0NSw2ICszNDgsOCBAQCB2b2lkIHF4 bF9tb2Rlc2V0X2Zpbmkoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYpOwo+ICBpbnQgcXhsX2JvX2lu aXQoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYpOwo+ICB2b2lkIHF4bF9ib19maW5pKHN0cnVjdCBx eGxfZGV2aWNlICpxZGV2KTsKPiAgCj4gK2ludCBxeGxfdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3Qg cXhsX2RldmljZSAqcWRldik7Cj4gKwoKUGxlYXNlIGdyb3VwIHRoaXMgZGVjbGFyYXRpb24gdG9n ZXRoZXIgd2l0aCB0aGUgb3RoZXIgcXhsIGRlYnVnZnMKZGVjbGFyYXRpb25zLgoKR3VzdGF2bwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==