From: Elise Lennion <elise.lennion@gmail.com>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH nft] src: Honor obligatory stateless printing of flow tables
Date: Wed, 18 Jan 2017 21:06:47 -0200 [thread overview]
Message-ID: <20170118230647.GA12926@lennorien.com> (raw)
Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
include/nftables.h | 2 +-
src/main.c | 4 ++--
src/statement.c | 4 ++++
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/nftables.h b/include/nftables.h
index 760bbff..6f54155 100644
--- a/include/nftables.h
+++ b/include/nftables.h
@@ -26,10 +26,10 @@ enum debug_level {
extern unsigned int max_errors;
extern unsigned int numeric_output;
+extern unsigned int stateless_output;
extern unsigned int ip2name_output;
extern unsigned int handle_output;
extern unsigned int debug_level;
-extern bool stateless_output;
extern const char *include_paths[INCLUDE_PATHS_MAX];
enum nftables_exit_codes {
diff --git a/src/main.c b/src/main.c
index 6d073d5..6ba752b 100644
--- a/src/main.c
+++ b/src/main.c
@@ -30,12 +30,12 @@
unsigned int max_errors = 10;
unsigned int numeric_output;
+unsigned int stateless_output;
unsigned int ip2name_output;
unsigned int handle_output;
#ifdef DEBUG
unsigned int debug_level;
#endif
-bool stateless_output;
const char *include_paths[INCLUDE_PATHS_MAX] = { DEFAULT_INCLUDE_PATH };
static unsigned int num_include_paths = 1;
@@ -291,7 +291,7 @@ int main(int argc, char * const *argv)
numeric_output++;
break;
case OPT_STATELESS:
- stateless_output = true;
+ stateless_output++;
break;
case OPT_IP2NAME:
ip2name_output++;
diff --git a/src/statement.c b/src/statement.c
index 7e2e448..20f37a6 100644
--- a/src/statement.c
+++ b/src/statement.c
@@ -109,6 +109,8 @@ struct stmt *verdict_stmt_alloc(const struct location *loc, struct expr *expr)
static void flow_stmt_print(const struct stmt *stmt)
{
+ stateless_output++;
+
printf("flow ");
if (stmt->flow.set) {
expr_print(stmt->flow.set, NULL);
@@ -119,6 +121,8 @@ static void flow_stmt_print(const struct stmt *stmt)
printf(" ");
stmt_print(stmt->flow.stmt);
printf("} ");
+
+ stateless_output--;
}
static void flow_stmt_destroy(struct stmt *stmt)
--
2.7.4
next reply other threads:[~2017-01-18 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 23:06 Elise Lennion [this message]
2017-01-23 13:32 ` [PATCH nft] src: Honor obligatory stateless printing of flow tables Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118230647.GA12926@lennorien.com \
--to=elise.lennion@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.