From: Stephen Boyd <sboyd@codeaurora.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Andy Gross <andy.gross@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] ARM: Makefile: Generalize qcom platform text offset
Date: Wed, 18 Jan 2017 15:51:21 -0800 [thread overview]
Message-ID: <20170118235121.GW17126@codeaurora.org> (raw)
In-Reply-To: <20170118233115.GV27312@n2100.armlinux.org.uk>
On 01/18, Russell King - ARM Linux wrote:
> On Wed, Jan 18, 2017 at 03:27:23PM -0800, Stephen Boyd wrote:
> > Some qcom platforms need a specific text offset because the first
> > 2MB of memory is reserved for shared memory. Let's just always
> > shift the text segment up by 2MB when ARCH_QCOM is selected so
> > that we don't have to specify the specific platforms that exhibit
> > this problem in Kconfig.
>
> I was really hoping that this sillyness would stop, but I guess
> expecting it to stop is asking too much...
>
> Is there really no other option?
>
The only other option is to make up some qcom specific config
like I_HAVE_A_QCOM_SOC_THAT_NEEDS_2MB_OFFSET that can be selected
when the configurator (not a word) knows that they are using that
SoC.
Overall, this practice has stopped inside the company over 3
years ago and has not continued as far as I know. This patch is
just taking the easy way out and forcing ARCH_QCOM to always do
the shift.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: Makefile: Generalize qcom platform text offset
Date: Wed, 18 Jan 2017 15:51:21 -0800 [thread overview]
Message-ID: <20170118235121.GW17126@codeaurora.org> (raw)
In-Reply-To: <20170118233115.GV27312@n2100.armlinux.org.uk>
On 01/18, Russell King - ARM Linux wrote:
> On Wed, Jan 18, 2017 at 03:27:23PM -0800, Stephen Boyd wrote:
> > Some qcom platforms need a specific text offset because the first
> > 2MB of memory is reserved for shared memory. Let's just always
> > shift the text segment up by 2MB when ARCH_QCOM is selected so
> > that we don't have to specify the specific platforms that exhibit
> > this problem in Kconfig.
>
> I was really hoping that this sillyness would stop, but I guess
> expecting it to stop is asking too much...
>
> Is there really no other option?
>
The only other option is to make up some qcom specific config
like I_HAVE_A_QCOM_SOC_THAT_NEEDS_2MB_OFFSET that can be selected
when the configurator (not a word) knows that they are using that
SoC.
Overall, this practice has stopped inside the company over 3
years ago and has not continued as far as I know. This patch is
just taking the easy way out and forcing ARCH_QCOM to always do
the shift.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-18 23:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 23:27 [PATCH 0/5] Remove qcom SoC configs Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
[not found] ` <20170118232726.22876-1-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-18 23:27 ` [PATCH 1/5] iommu: Generalize MSM_IOMMU config to ARCH_QCOM Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
[not found] ` <20170118232726.22876-2-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-26 16:58 ` Joerg Roedel
2017-01-26 16:58 ` Joerg Roedel
2017-01-26 16:58 ` Joerg Roedel
2017-01-18 23:27 ` [PATCH 2/5] ARM: Makefile: Generalize qcom platform text offset Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
2017-01-18 23:31 ` Russell King - ARM Linux
2017-01-18 23:31 ` Russell King - ARM Linux
2017-01-18 23:51 ` Stephen Boyd [this message]
2017-01-18 23:51 ` Stephen Boyd
2017-01-18 23:27 ` [PATCH 3/5] ARM: qcom: Remove SoC specific configs Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
2017-01-18 23:27 ` [PATCH 4/5] ARM: qcom_defconfig: Drop " Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
2017-01-18 23:27 ` [PATCH 5/5] ARM: multi_v7_defconfig: Remove qcom SoC configs Stephen Boyd
2017-01-18 23:27 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118235121.GW17126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.