All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org
Subject: [bug report] blk-mq-sched: add framework for MQ capable IO schedulers
Date: Thu, 19 Jan 2017 10:32:38 +0300	[thread overview]
Message-ID: <20170119073238.GA9834@mwanda> (raw)

Hello Jens Axboe,

This is a semi-automatic email about new static checker warnings.

The patch bd166ef183c2: "blk-mq-sched: add framework for MQ capable
IO schedulers" from Jan 17, 2017, leads to the following Smatch
complaint:

block/elevator.c:234 elevator_init()
	 error: we previously assumed 'e' could be null (see line 229)

block/elevator.c
   228	
   229			if (!e) {
                            ^^
Null.

   230				printk(KERN_ERR
   231					"Default I/O scheduler not found. " \
   232					"Using noop/none.\n");
   233				if (q->mq_ops) {
   234					elevator_put(e);
                                        ^^^^^^^^^^^^^^^
This will Oops.

   235					return 0;
   236				}

regards,
dan carpenter

             reply	other threads:[~2017-01-19  7:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  7:32 Dan Carpenter [this message]
2017-01-19 14:11 ` [bug report] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119073238.GA9834@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=axboe@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.