From: Vinod Koul <vinod.koul@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [bug report] ASoC: dapm: Implement and instantiate DAI widgets
Date: Thu, 19 Jan 2017 14:50:46 +0530 [thread overview]
Message-ID: <20170119092046.GK3573@localhost> (raw)
In-Reply-To: <20170119073826.GA28899@mwanda>
On Thu, Jan 19, 2017 at 10:38:26AM +0300, Dan Carpenter wrote:
> Hello Mark Brown,
Dan you need to update Mark's email in your address book, its been a while
since he moved away from wolfson..
>
> The patch 888df395ebc5: "ASoC: dapm: Implement and instantiate DAI
> widgets" from Feb 16, 2012, leads to the following static checker
> warning:
>
> sound/soc/soc-dapm.c:3944 snd_soc_dapm_new_dai_widgets()
> error: 'w' dereferencing possible ERR_PTR()
>
> sound/soc/soc-dapm.c
> 3929 if (dai->driver->playback.stream_name) {
> 3930 template.id = snd_soc_dapm_dai_in;
> 3931 template.name = dai->driver->playback.stream_name;
> 3932 template.sname = dai->driver->playback.stream_name;
> 3933
> 3934 dev_dbg(dai->dev, "ASoC: adding %s widget\n",
> 3935 template.name);
> 3936
> 3937 w = snd_soc_dapm_new_control_unlocked(dapm, &template);
>
> This can either return NULL or ERR_PTR(-EPROBE_DEFER).
>
> 3938 if (!w) {
> 3939 dev_err(dapm->dev, "ASoC: Failed to create %s widget\n",
> 3940 dai->driver->playback.stream_name);
> 3941 return -ENOMEM;
> 3942 }
> 3943
> 3944 w->priv = dai;
> ^^^^^^^^^^^^^
>
> 3945 dai->playback_widget = w;
> 3946 }
>
> regards,
> dan carpenter
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
~Vinod
next prev parent reply other threads:[~2017-01-19 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 7:38 [bug report] ASoC: dapm: Implement and instantiate DAI widgets Dan Carpenter
2017-01-19 7:43 ` Dan Carpenter
2017-01-19 9:20 ` Vinod Koul [this message]
2017-01-19 10:30 ` Dan Carpenter
2017-01-19 12:25 ` Lars-Peter Clausen
2017-01-20 9:52 ` Linus Walleij
2017-01-20 12:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119092046.GK3573@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.carpenter@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.