diff for duplicates of <20170119110520.24dfd34d@xeon-e3> diff --git a/a/1.txt b/N1/1.txt index 390f85e..54a4efa 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,38 +1,41 @@ On Thu, 19 Jan 2017 03:45:10 +0100 -Linus Lüssing <linus.luessing@c0d3.blue> wrote: +Linus L=C3=BCssing <linus.luessing@c0d3.blue> wrote: > From: Felix Fietkau <nbd@nbd.name> -> +>=20 > Implements an optional, per bridge port flag and feature to deliver > multicast packets to any host on the according port via unicast > individually. This is done by copying the packet per host and > changing the multicast destination MAC to a unicast one accordingly. -> +>=20 > multicast-to-unicast works on top of the multicast snooping feature of > the bridge. Which means unicast copies are only delivered to hosts which > are interested in it and signalized this via IGMP/MLD reports > previously. -> +>=20 > This feature is intended for interface types which have a more reliable > and/or efficient way to deliver unicast packets than broadcast ones > (e.g. wifi). -> +>=20 > However, it should only be enabled on interfaces where no IGMPv2/MLDv1 > report suppression takes place. This feature is disabled by default. -> +>=20 > The initial patch and idea is from Felix Fietkau. -> +>=20 > Signed-off-by: Felix Fietkau <nbd@nbd.name> > [linus.luessing@c0d3.blue: various bug + style fixes, commit message] -> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue> -> +> Signed-off-by: Linus L=C3=BCssing <linus.luessing@c0d3.blue> +>=20 In general this looks good. -One issue I see is how existing entries are handled when the bridge port flags -are changed dynamically. It might be better to always record the necessary data +One issue I see is how existing entries are handled when the bridge port fl= +ags +are changed dynamically. It might be better to always record the necessary = +data in the bridge_port_group and not have a per-entry flag bit. In your current patch the API changes the response to future IGMP but does not take instant -effect. Code would be simpler if there was less logic to handle per-entry flags. +effect. Code would be simpler if there was less logic to handle per-entry f= +lags. Also, you might want to add sysfs interface for the attribute as well. diff --git a/a/content_digest b/N1/content_digest index 47e4da8..23766d7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,54 +1,57 @@ "ref\020170119024510.3284-1-linus.luessing@c0d3.blue\0" "From\0Stephen Hemminger <stephen@networkplumber.org>\0" - "Subject\0Re: [Bridge] [PATCH net-next v4] bridge: multicast to unicast\0" + "Subject\0Re: [PATCH net-next v4] bridge: multicast to unicast\0" "Date\0Thu, 19 Jan 2017 11:05:20 -0800\0" "To\0Linus L\303\274ssing <linus.luessing@c0d3.blue>\0" - "Cc\0Nikolay Aleksandrov <nikolay@cumulusnetworks.com>" - netdev@vger.kernel.org + "Cc\0netdev@vger.kernel.org" + David S . Miller <davem@davemloft.net> + Felix Fietkau <nbd@nbd.name> + Nikolay Aleksandrov <nikolay@cumulusnetworks.com> bridge@lists.linux-foundation.org - linux-wireless@vger.kernel.org linux-kernel@vger.kernel.org - David S . Miller <davem@davemloft.net> - " Felix Fietkau <nbd@nbd.name>\0" + " linux-wireless@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, 19 Jan 2017 03:45:10 +0100\n" - "Linus L\303\274ssing <linus.luessing@c0d3.blue> wrote:\n" + "Linus L=C3=BCssing <linus.luessing@c0d3.blue> wrote:\n" "\n" "> From: Felix Fietkau <nbd@nbd.name>\n" - "> \n" + ">=20\n" "> Implements an optional, per bridge port flag and feature to deliver\n" "> multicast packets to any host on the according port via unicast\n" "> individually. This is done by copying the packet per host and\n" "> changing the multicast destination MAC to a unicast one accordingly.\n" - "> \n" + ">=20\n" "> multicast-to-unicast works on top of the multicast snooping feature of\n" "> the bridge. Which means unicast copies are only delivered to hosts which\n" "> are interested in it and signalized this via IGMP/MLD reports\n" "> previously.\n" - "> \n" + ">=20\n" "> This feature is intended for interface types which have a more reliable\n" "> and/or efficient way to deliver unicast packets than broadcast ones\n" "> (e.g. wifi).\n" - "> \n" + ">=20\n" "> However, it should only be enabled on interfaces where no IGMPv2/MLDv1\n" "> report suppression takes place. This feature is disabled by default.\n" - "> \n" + ">=20\n" "> The initial patch and idea is from Felix Fietkau.\n" - "> \n" + ">=20\n" "> Signed-off-by: Felix Fietkau <nbd@nbd.name>\n" "> [linus.luessing@c0d3.blue: various bug + style fixes, commit message]\n" - "> Signed-off-by: Linus L\303\274ssing <linus.luessing@c0d3.blue>\n" - "> \n" + "> Signed-off-by: Linus L=C3=BCssing <linus.luessing@c0d3.blue>\n" + ">=20\n" "\n" "In general this looks good.\n" "\n" - "One issue I see is how existing entries are handled when the bridge port flags\n" - "are changed dynamically. It might be better to always record the necessary data\n" + "One issue I see is how existing entries are handled when the bridge port fl=\n" + "ags\n" + "are changed dynamically. It might be better to always record the necessary =\n" + "data\n" "in the bridge_port_group and not have a per-entry flag bit. In your current\n" "patch the API changes the response to future IGMP but does not take instant\n" - "effect. Code would be simpler if there was less logic to handle per-entry flags.\n" + "effect. Code would be simpler if there was less logic to handle per-entry f=\n" + "lags.\n" "\n" Also, you might want to add sysfs interface for the attribute as well. -3ed6ae52ff296fce5c4522fd4a56f04ed00578994140e4e79e842476f54db1b1 +a7b56f75b3094ed71078e93c731cfc54ab503da768311846d26a0b5bf735fa2e
diff --git a/a/content_digest b/N2/content_digest index 47e4da8..3641e97 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,15 +1,15 @@ "ref\020170119024510.3284-1-linus.luessing@c0d3.blue\0" "From\0Stephen Hemminger <stephen@networkplumber.org>\0" - "Subject\0Re: [Bridge] [PATCH net-next v4] bridge: multicast to unicast\0" + "Subject\0Re: [PATCH net-next v4] bridge: multicast to unicast\0" "Date\0Thu, 19 Jan 2017 11:05:20 -0800\0" "To\0Linus L\303\274ssing <linus.luessing@c0d3.blue>\0" - "Cc\0Nikolay Aleksandrov <nikolay@cumulusnetworks.com>" - netdev@vger.kernel.org + "Cc\0netdev@vger.kernel.org" + David S . Miller <davem@davemloft.net> + Felix Fietkau <nbd@nbd.name> + Nikolay Aleksandrov <nikolay@cumulusnetworks.com> bridge@lists.linux-foundation.org - linux-wireless@vger.kernel.org linux-kernel@vger.kernel.org - David S . Miller <davem@davemloft.net> - " Felix Fietkau <nbd@nbd.name>\0" + " linux-wireless@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, 19 Jan 2017 03:45:10 +0100\n" @@ -51,4 +51,4 @@ "\n" Also, you might want to add sysfs interface for the attribute as well. -3ed6ae52ff296fce5c4522fd4a56f04ed00578994140e4e79e842476f54db1b1 +1f5f4af4dd670317592fc1106836d138090cafdd17086cbd967d13715f4dc8b3
diff --git a/a/content_digest b/N3/content_digest index 47e4da8..d7dfc3e 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,6 +1,6 @@ "ref\020170119024510.3284-1-linus.luessing@c0d3.blue\0" "From\0Stephen Hemminger <stephen@networkplumber.org>\0" - "Subject\0Re: [Bridge] [PATCH net-next v4] bridge: multicast to unicast\0" + "Subject\0Re: [PATCH net-next v4] bridge: multicast to unicast\0" "Date\0Thu, 19 Jan 2017 11:05:20 -0800\0" "To\0Linus L\303\274ssing <linus.luessing@c0d3.blue>\0" "Cc\0Nikolay Aleksandrov <nikolay@cumulusnetworks.com>" @@ -51,4 +51,4 @@ "\n" Also, you might want to add sysfs interface for the attribute as well. -3ed6ae52ff296fce5c4522fd4a56f04ed00578994140e4e79e842476f54db1b1 +7b09ab9834de65850c8079579ffe8616b4d7eb2e40a919856a1bc8d404fb952e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.