From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] xennet_start_xmit assumptions
Date: Thu, 19 Jan 2017 06:14:26 -0500 [thread overview]
Message-ID: <20170119111426.GA22018@oracle.com> (raw)
In-Reply-To: <de0d7a7db4c24b46838aee7623d5d2a3@AMSPEX02CL03.citrite.net>
On (01/19/17 09:36), Paul Durrant wrote:
>
> Hi Sowmini,
>
> Sounds like a straightforward bug to me... netfront should be able
> to handle an empty skb and clearly, if it's relying on skb_headlen()
> being non-zero, that's not the case.
>
> Paul
I see. Seems like there are 2 things broken here: recovering
from skb->len = 0, and recovering from the more complex
case of (skb->len > 0 && skb_headlen(skb) == 0)
Do you folks want to take a shot at fixing this,
since you know the code better? If you are interested,
I can share my test program to help you reproduce the
simpler skb->len == 0 case, but it's the fully non-linear
skbs that may be more interesting to reproduce/fix.
I'll probably work on fixing packet_snd to return -EINVAL
or similar when the len is zero this week.
--Sowmini
next prev parent reply other threads:[~2017-01-19 11:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 15:31 xennet_start_xmit assumptions Sowmini Varadhan
2017-01-18 19:25 ` Konrad Rzeszutek Wilk
2017-01-18 19:25 ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-01-19 9:36 ` Paul Durrant
2017-01-19 11:14 ` Sowmini Varadhan
2017-01-19 11:14 ` Sowmini Varadhan [this message]
2017-01-19 11:31 ` Paul Durrant
2017-01-19 11:37 ` Sowmini Varadhan
2017-01-19 11:37 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 16:37 ` David Miller
2017-01-19 18:47 ` Sowmini Varadhan
2017-01-19 22:41 ` [Xen-devel] " Sowmini Varadhan
2017-01-20 19:30 ` David Miller
2017-01-20 19:30 ` [Xen-devel] " David Miller
2017-01-20 20:03 ` Sowmini Varadhan
2017-01-20 20:03 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 22:41 ` Sowmini Varadhan
2017-01-25 15:06 ` Paul Durrant
2017-01-25 15:06 ` [Xen-devel] " Paul Durrant
2017-01-25 15:45 ` Sowmini Varadhan
2017-01-25 15:45 ` [Xen-devel] " Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119111426.GA22018@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=Paul.Durrant@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.