From: Josef Gajdusek <atx@atx.name>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, maitysanchayan@gmail.com,
gregor.boirie@parrot.com, linux-kernel@vger.kernel.org,
rui.zhang@intel.com, marxin.liska@gmail.com, marex@denx.de,
atx@atx.name
Subject: [PATCH v2] iio: light: acpi-als: Properly enable on ASUS Zenbooks
Date: Thu, 19 Jan 2017 12:48:17 +0100 [thread overview]
Message-ID: <20170119114816.GA12918@rick.lan> (raw)
ASUS Zenbooks need several special ACPI calls to enable the ALS peripheral.
Otherwise, reads just return 0.
Signed-off-by: Josef Gajdusek <atx@atx.name>
---
drivers/iio/light/acpi-als.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
index f0b47c5..ccd5787 100644
--- a/drivers/iio/light/acpi-als.c
+++ b/drivers/iio/light/acpi-als.c
@@ -39,6 +39,9 @@
#define ACPI_ALS_DEVICE_NAME "acpi-als"
#define ACPI_ALS_NOTIFY_ILLUMINANCE 0x80
+#define ACPI_ALS_ASUS_TALS "\\_SB.PCI0.LPCB.EC0.TALS"
+#define ACPI_ALS_ASUS_ALSC "\\_SB.ATKD.ALSC"
+
ACPI_MODULE_NAME("acpi-als");
/*
@@ -170,6 +173,16 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,
return IIO_VAL_INT;
}
+static void acpi_als_quirk_asus(struct acpi_als *als)
+{
+ acpi_execute_simple_method(NULL, ACPI_ALS_ASUS_TALS, 1);
+ acpi_execute_simple_method(NULL, ACPI_ALS_ASUS_ALSC, 1);
+}
+
+static void (*acpi_als_quirks[])(struct acpi_als *als) = {
+ acpi_als_quirk_asus,
+};
+
static const struct iio_info acpi_als_info = {
.driver_module = THIS_MODULE,
.read_raw = acpi_als_read_raw,
@@ -180,6 +193,7 @@ static int acpi_als_add(struct acpi_device *device)
struct acpi_als *als;
struct iio_dev *indio_dev;
struct iio_buffer *buffer;
+ int i;
indio_dev = devm_iio_device_alloc(&device->dev, sizeof(*als));
if (!indio_dev)
@@ -191,6 +205,9 @@ static int acpi_als_add(struct acpi_device *device)
als->device = device;
mutex_init(&als->lock);
+ for (i = 0; i < ARRAY_SIZE(acpi_als_quirks); i++)
+ acpi_als_quirks[i](als);
+
indio_dev->name = ACPI_ALS_DEVICE_NAME;
indio_dev->dev.parent = &device->dev;
indio_dev->info = &acpi_als_info;
--
2.10.2
next reply other threads:[~2017-01-19 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 11:48 Josef Gajdusek [this message]
2017-01-19 14:48 ` [PATCH v2] iio: light: acpi-als: Properly enable on ASUS Zenbooks Marek Vasut
2017-01-19 16:19 ` atx
2017-01-19 16:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119114816.GA12918@rick.lan \
--to=atx@atx.name \
--cc=gregor.boirie@parrot.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=marex@denx.de \
--cc=marxin.liska@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.