From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, dave@recoil.org
Subject: Re: [PATCH] xenstore: remove XS_RESTRICT support
Date: Thu, 19 Jan 2017 13:58:45 +0000 [thread overview]
Message-ID: <20170119135845.GP5089@citrix.com> (raw)
In-Reply-To: <c83b8a91-e32f-3c6f-8e5c-d338d7a60fde@citrix.com>
On Thu, Jan 19, 2017 at 01:56:34PM +0000, Andrew Cooper wrote:
> On 19/01/17 11:01, Wei Liu wrote:
> > On Wed, Jan 18, 2017 at 07:15:44PM +0100, Juergen Gross wrote:
> > [...]
> >> diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h
> >> index 54c1d71..751bd17 100644
> >> --- a/xen/include/public/io/xs_wire.h
> >> +++ b/xen/include/public/io/xs_wire.h
> >> @@ -48,7 +48,7 @@ enum xsd_sockmsg_type
> >> XS_IS_DOMAIN_INTRODUCED,
> >> XS_RESUME,
> >> XS_SET_TARGET,
> >> - XS_RESTRICT,
> >> + XS_PAD_1, /* XS_RESTRICT has been removed */
> > XS_RESERVED_0/1 is better.
> >
> > Other than this, the modification looks good.
>
> How about?
>
> XS_SET_TARGET,
> /* XS_RESTRICT has been removed */
> XS_RESET_WATCHES = XS_SET_TARGET + 2,
>
> This doesn't involve adding an pad/reserved identifier.
>
Fine by me. I don't really feel strongly about this.
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-01-19 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 18:15 [PATCH] xenstore: remove XS_RESTRICT support Juergen Gross
2017-01-19 11:01 ` Wei Liu
2017-01-19 13:56 ` Andrew Cooper
2017-01-19 13:58 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119135845.GP5089@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dave@recoil.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.