From: Jiri Benc <jbenc@redhat.com>
To: Paul Blakey <paulb@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>, Roi Dayan <roid@mellanox.com>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly
Date: Thu, 19 Jan 2017 15:04:47 +0100 [thread overview]
Message-ID: <20170119150447.6b9ad397@griffin> (raw)
In-Reply-To: <1484828277-29178-1-git-send-email-paulb@mellanox.com>
On Thu, 19 Jan 2017 14:17:57 +0200, Paul Blakey wrote:
> Instead of "magic numbers" we can now specify each flag
> by name. Prefix of "no_" (e.g no_frag) unsets the flag,
> otherwise it wil be set.
Other parts of the tc tool use the "no" prefix (without the
underscore), such as "nofrag" in u32 and pedit, "noecn" in fq_codel and
pie, etc. We should follow the suit here.
Looks good to me otherwise, thanks a lot for doing the work!
Jiri
next prev parent reply other threads:[~2017-01-19 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 12:17 [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly Paul Blakey
2017-01-19 14:04 ` Jiri Benc [this message]
2017-01-19 14:14 ` Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119150447.6b9ad397@griffin \
--to=jbenc@redhat.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.