From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Johannes Thumshirn <jth@kernel.org>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH] scsi: mq queue stall during command requeue
Date: Thu, 19 Jan 2017 16:12:38 +0100 [thread overview]
Message-ID: <20170119151238.GA32178@lst.de> (raw)
In-Reply-To: <31a4a94c-5cd7-ef45-7103-c61a0d60ab46@kernel.dk>
On Thu, Jan 19, 2017 at 06:58:09AM -0800, Jens Axboe wrote:
> Yeah, I made that patch and grepped the tree. The usage in the fc
> code in nvme looks weird. It's stopping all potential hardware queues,
> yet only delaying one.
>
> if (op->rq) {
> blk_mq_stop_hw_queues(op->rq->q);
> blk_mq_delay_queue(queue->hctx, NVMEFC_QUEUE_DELAY);
> }
> return BLK_MQ_RQ_QUEUE_BUSY;
>
> James/Christoph, what's going on there? I'm going to leave that one
> as-is for now, but add the stop to the delay. If the above stop-all is
> indeed buggy, then it can later just be removed.
It looks broken to me, but I'll need James to confirm.
next prev parent reply other threads:[~2017-01-19 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 14:17 [PATCH] scsi: mq queue stall during command requeue Hannes Reinecke
2017-01-19 14:46 ` Christoph Hellwig
2017-01-19 14:52 ` Hannes Reinecke
2017-01-19 14:58 ` Jens Axboe
2017-01-19 15:12 ` Christoph Hellwig [this message]
2017-01-19 16:11 ` Bart Van Assche
2017-01-20 7:24 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119151238.GA32178@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=james.smart@broadcom.com \
--cc=jth@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.