From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 1/1] iommu/arm-smmu: Fix for ThunderX erratum #27704 Date: Thu, 19 Jan 2017 16:16:16 +0000 Message-ID: <20170119161615.GH31594@arm.com> References: <1484550967-6328-1-git-send-email-tn@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1484550967-6328-1-git-send-email-tn-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tomasz Nowicki Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, Prasun.Kapoor-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, Sunil.Goutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tirumalesh.Chalamarla-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, Geethasowjanya.Akula-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Linu.Cherian-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Jan 16, 2017 at 08:16:07AM +0100, Tomasz Nowicki wrote: > The goal of erratum #27704 workaround was to make sure that ASIDs and VMIDs > are unique across all SMMU instances on affected Cavium systems. > > Currently, the workaround code partitions ASIDs and VMIDs by increasing > global cavium_smmu_context_count which in turn becomes the base ASID and VMID > value for the given SMMU instance upon the context bank initialization. > > For systems with multiple SMMU instances this approach implies the risk > of crossing 8-bit ASID, like for 1-socket CN88xx capable of 4 SMMUv2, > 128 context banks each: > SMMU_0 (0-127 ASID RANGE) > SMMU_1 (127-255 ASID RANGE) > SMMU_2 (256-383 ASID RANGE) <--- crossing 8-bit ASID > SMMU_3 (384-511 ASID RANGE) <--- crossing 8-bit ASID > > Since now we use 8-bit ASID (SMMU_CBn_TCR2.AS = 0) we effectively misconfigure > ASID[15:8] bits of SMMU_CBn_TTBRm register for SMMU_2/3. Moreover, we still > assume non-zero ASID[15:8] bits upon context invalidation. In the end, > except SMMU_0/1 devices all other devices under other SMMUs will fail on guest > power off/on. Since we try to invalidate TLB with 16-bit ASID but we actually > have 8-bit zero padded 16-bit entry. > > This patch adds 16-bit ASID support for stage-1 AArch64 contexts so that > we use ASIDs consistently for all SMMU instances. > > Signed-off-by: Tomasz Nowicki > Reviewed-by: Robin Murphy > Reviewed-by: Tirumalesh Chalamarla > --- > drivers/iommu/arm-smmu.c | 3 +++ > 1 file changed, 3 insertions(+) Thanks, queued for 4.11. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Thu, 19 Jan 2017 16:16:16 +0000 Subject: [PATCH 1/1] iommu/arm-smmu: Fix for ThunderX erratum #27704 In-Reply-To: <1484550967-6328-1-git-send-email-tn@semihalf.com> References: <1484550967-6328-1-git-send-email-tn@semihalf.com> Message-ID: <20170119161615.GH31594@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 16, 2017 at 08:16:07AM +0100, Tomasz Nowicki wrote: > The goal of erratum #27704 workaround was to make sure that ASIDs and VMIDs > are unique across all SMMU instances on affected Cavium systems. > > Currently, the workaround code partitions ASIDs and VMIDs by increasing > global cavium_smmu_context_count which in turn becomes the base ASID and VMID > value for the given SMMU instance upon the context bank initialization. > > For systems with multiple SMMU instances this approach implies the risk > of crossing 8-bit ASID, like for 1-socket CN88xx capable of 4 SMMUv2, > 128 context banks each: > SMMU_0 (0-127 ASID RANGE) > SMMU_1 (127-255 ASID RANGE) > SMMU_2 (256-383 ASID RANGE) <--- crossing 8-bit ASID > SMMU_3 (384-511 ASID RANGE) <--- crossing 8-bit ASID > > Since now we use 8-bit ASID (SMMU_CBn_TCR2.AS = 0) we effectively misconfigure > ASID[15:8] bits of SMMU_CBn_TTBRm register for SMMU_2/3. Moreover, we still > assume non-zero ASID[15:8] bits upon context invalidation. In the end, > except SMMU_0/1 devices all other devices under other SMMUs will fail on guest > power off/on. Since we try to invalidate TLB with 16-bit ASID but we actually > have 8-bit zero padded 16-bit entry. > > This patch adds 16-bit ASID support for stage-1 AArch64 contexts so that > we use ASIDs consistently for all SMMU instances. > > Signed-off-by: Tomasz Nowicki > Reviewed-by: Robin Murphy > Reviewed-by: Tirumalesh Chalamarla > --- > drivers/iommu/arm-smmu.c | 3 +++ > 1 file changed, 3 insertions(+) Thanks, queued for 4.11. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717AbdASQ2Z (ORCPT ); Thu, 19 Jan 2017 11:28:25 -0500 Received: from foss.arm.com ([217.140.101.70]:57752 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753474AbdASQ1z (ORCPT ); Thu, 19 Jan 2017 11:27:55 -0500 Date: Thu, 19 Jan 2017 16:16:16 +0000 From: Will Deacon To: Tomasz Nowicki Cc: robin.murphy@arm.com, mark.rutland@arm.com, joro@8bytes.org, Linu.Cherian@cavium.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Sunil.Goutham@cavium.com, Geethasowjanya.Akula@cavium.com, Tirumalesh.Chalamarla@cavium.com, Prasun.Kapoor@cavium.com Subject: Re: [PATCH 1/1] iommu/arm-smmu: Fix for ThunderX erratum #27704 Message-ID: <20170119161615.GH31594@arm.com> References: <1484550967-6328-1-git-send-email-tn@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484550967-6328-1-git-send-email-tn@semihalf.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 08:16:07AM +0100, Tomasz Nowicki wrote: > The goal of erratum #27704 workaround was to make sure that ASIDs and VMIDs > are unique across all SMMU instances on affected Cavium systems. > > Currently, the workaround code partitions ASIDs and VMIDs by increasing > global cavium_smmu_context_count which in turn becomes the base ASID and VMID > value for the given SMMU instance upon the context bank initialization. > > For systems with multiple SMMU instances this approach implies the risk > of crossing 8-bit ASID, like for 1-socket CN88xx capable of 4 SMMUv2, > 128 context banks each: > SMMU_0 (0-127 ASID RANGE) > SMMU_1 (127-255 ASID RANGE) > SMMU_2 (256-383 ASID RANGE) <--- crossing 8-bit ASID > SMMU_3 (384-511 ASID RANGE) <--- crossing 8-bit ASID > > Since now we use 8-bit ASID (SMMU_CBn_TCR2.AS = 0) we effectively misconfigure > ASID[15:8] bits of SMMU_CBn_TTBRm register for SMMU_2/3. Moreover, we still > assume non-zero ASID[15:8] bits upon context invalidation. In the end, > except SMMU_0/1 devices all other devices under other SMMUs will fail on guest > power off/on. Since we try to invalidate TLB with 16-bit ASID but we actually > have 8-bit zero padded 16-bit entry. > > This patch adds 16-bit ASID support for stage-1 AArch64 contexts so that > we use ASIDs consistently for all SMMU instances. > > Signed-off-by: Tomasz Nowicki > Reviewed-by: Robin Murphy > Reviewed-by: Tirumalesh Chalamarla > --- > drivers/iommu/arm-smmu.c | 3 +++ > 1 file changed, 3 insertions(+) Thanks, queued for 4.11. Will