From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUG89-0006P9-EK for qemu-devel@nongnu.org; Thu, 19 Jan 2017 12:04:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUG88-0006ke-H2 for qemu-devel@nongnu.org; Thu, 19 Jan 2017 12:04:09 -0500 Date: Thu, 19 Jan 2017 17:03:55 +0000 From: "Daniel P. Berrange" Message-ID: <20170119170355.GF16641@redhat.com> Reply-To: "Daniel P. Berrange" References: <0bb184fe-d348-a1d4-ac14-0f02f070c287@kamp.de> <20170119163845.GC16641@redhat.com> <8e98321f-70ce-f86a-37d3-de2c1a5f45bd@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8e98321f-70ce-f86a-37d3-de2c1a5f45bd@kamp.de> Subject: Re: [Qemu-devel] qemu-img: complains about missing iscsi option group List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu block , Kevin Wolf , pbonzini@redhat.com, "qemu-devel@nongnu.org" , Max Reitz On Thu, Jan 19, 2017 at 05:57:45PM +0100, Peter Lieven wrote: > Am 19.01.2017 um 17:38 schrieb Daniel P. Berrange: > > On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote: > > > Hi all, > > > > > > > > > since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading) > > > > > > qemu-img complains about a missing option group several times. > > > > > > > > > ~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0 > > > qemu-img: There is no option group 'iscsi' > > > qemu-img: There is no option group 'iscsi' > > > qemu-img: There is no option group 'iscsi' > > > qemu-img: There is no option group 'iscsi' > > > image: iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0 > > > file format: raw > > > virtual size: 25G (26848788480 bytes) > > > disk size: unavailable > > > cluster_size: 15728640 > > > > > > I don't know whats the proper way to fix this? > > Move the iscsi option registration out of vl.c and back into a shared file > > in block/ such that all programs see the options, not just the emulators. > > Any preference which file? It seems no other block driver registers options. ISCSI is somewhat bizarre in that it has a separate global -iscsi arg instead of just accepting all args via the -drive spec like every other block driver does, so there's no precedent to follow. So suggest we just need a block/iscsi-global.c to deal with this. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|