Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address

From: Denys Dmytriyenko <denis@denix.org>
To: Rick Altherr <raltherr@google.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
Date: Thu, 19 Jan 2017 12:37:00 -0500	[thread overview]
Message-ID: <20170119173700.GX15833@denix.org> (raw)
In-Reply-To: <20170119165803.22583-1-raltherr@google.com>

On Thu, Jan 19, 2017 at 08:58:03AM -0800, Rick Altherr wrote:
> If the ramdisk load and entry parameters are omitted in the FIT image
> specification, U-Boot will determine if the ramdisk needs to be
> relocated and will automatically allocate a location in RAM if so.

Sometimes it's useful to load ramdisk in a specific location. Your patch 
unconditionally removes this support, which is not a desired change. I have 
a patch queued up to do it conditionally, which I'll try to submit shortly.

-- 
Denys

> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>  meta/classes/kernel-fitimage.bbclass | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 2934b3a31a..ee721d1fff 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -187,8 +187,6 @@ fitimage_emit_section_ramdisk() {
>                          arch = "${UBOOT_ARCH}";
>                          os = "linux";
>                          compression = "none";
> -                        load = <${UBOOT_RD_LOADADDRESS}>;
> -                        entry = <${UBOOT_RD_ENTRYPOINT}>;
>                          hash@1 {
>                                  algo = "${ramdisk_csum}";
>                          };
> -- 
> 2.11.0.483.g087da7b7c-goog
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core