From: Larry Finger <Larry.Finger@lwfinger.net>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: [PATCH 0/3 v2] rtlwifi: Patches for proper operation on big-endian hardware
Date: Thu, 19 Jan 2017 14:28:05 -0600 [thread overview]
Message-ID: <20170119202808.27752-1-Larry.Finger@lwfinger.net> (raw)
Although these drivers do not have any Sparse messages indication
problems with endian operations, there are two places where the
information being processed is little endian, but was being processed
in cpu order. The first of these is in downloading firmware. Rather
than do a double conversion for BE hosts, I converted the firmware
download routines to send bytes rather than 32-bit quantities. The
number of I/O operations in increased, but firmware download is usually
done only once.
A second problem is that the USB driver requires that the descriptors
be checksummed before transmission to the device so that critical info
such as DMA addresses are not garbled in transmission. The original
code was calculating the checksum in cpu order.
There is also a third change that causes the USB driver rtl8192cu to use
the same set of macros to read and write the descriptors. This change was
no necessary; however, it simplifies the code, and did identify an endian
problem in the macros. Using identical macros for PCI- and USB-based
hardware increases the likelihood that the PCI devices will work with BE
hardware. At the moment, we do not have such hardware for testing.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>
V2 - No functional changes. Merge conflict resolved.
Larry Finger (3):
rtlwifi: Download firmware as bytes rather than as dwords
rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE
rtlwifi: rtl8192cu: Convert driver to use common macros
drivers/net/wireless/realtek/rtlwifi/efuse.c | 45 ++++
drivers/net/wireless/realtek/rtlwifi/efuse.h | 4 +
.../net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 67 +----
.../wireless/realtek/rtlwifi/rtl8192c/fw_common.c | 70 +-----
.../net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 4 +-
.../net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 272 ++++++++++-----------
.../net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 70 +-----
.../net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 68 +-----
.../realtek/rtlwifi/rtl8723com/fw_common.c | 69 +-----
.../realtek/rtlwifi/rtl8723com/fw_common.h | 6 -
.../net/wireless/realtek/rtlwifi/rtl8821ae/fw.c | 67 +----
drivers/net/wireless/realtek/rtlwifi/wifi.h | 23 +-
12 files changed, 219 insertions(+), 546 deletions(-)
--
2.10.2
next reply other threads:[~2017-01-19 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 20:28 Larry Finger [this message]
2017-01-19 20:28 ` [PATCH v2 1/3] rtlwifi: Download firmware as bytes rather than as dwords Larry Finger
2017-01-20 10:06 ` [v2, " Kalle Valo
2017-01-19 20:28 ` [PATCH v2 2/3] rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE Larry Finger
2017-01-19 20:28 ` [PATCH v2 3/3] rtlwifi: rtl8192cu: Convert driver to use common macros Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119202808.27752-1-Larry.Finger@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.