From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect Date: Thu, 19 Jan 2017 12:39:14 -0800 Message-ID: <20170119203914.GB30684@intel.com> References: <1483082068-5833-1-git-send-email-dhinakaran.pandiyan@intel.com> <20170117174041.GB15796@intel.com> <20170119134234.GY31595@intel.com> <20170119190101.GA30494@intel.com> <20170119192636.GZ31595@intel.com> <20170119193855.GA30684@intel.com> <20170119195954.GB31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2577F6EACC for ; Thu, 19 Jan 2017 20:40:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170119195954.GB31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , jani.nikula@linux.intel.com, daniel.vetter@ffwll.ch Cc: Ander Conselvande Oliveira , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTksIDIwMTcgYXQgMDk6NTk6NTRQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgSmFuIDE5LCAyMDE3IGF0IDExOjM4OjU2QU0gLTA4MDAsIE1hbmFz aSBOYXZhcmUgd3JvdGU6Cj4gPiBPbiBUaHUsIEphbiAxOSwgMjAxNyBhdCAwOToyNjozNlBNICsw MjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFRodSwgSmFuIDE5LCAyMDE3IGF0 IDExOjAxOjAxQU0gLTA4MDAsIE1hbmFzaSBOYXZhcmUgd3JvdGU6Cj4gPiA+ID4gT24gVGh1LCBK YW4gMTksIDIwMTcgYXQgMDM6NDI6MzRQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ ID4gPiA+ID4gT24gVHVlLCBKYW4gMTcsIDIwMTcgYXQgMDk6NDA6NDJBTSAtMDgwMCwgTWFuYXNp IE5hdmFyZSB3cm90ZToKPiA+ID4gPiA+ID4gSSBoYXZlIHZlcmlmaWVkIHRoaXMgcGF0Y2ggd2l0 aCB0aGUgbGF0ZXN0IGRybS10aXAgYW5kIGl0IGlzIGFsc28KPiA+ID4gPiA+ID4gYWJzb2x1dGVs eSBuZWNlc3NhcnkgdG8gZW5zdXJlIHRoZSBsaW5rIGdldHMgcHJvcGVybHkgcmV0cmFpbmVkCj4g PiA+ID4gPiA+IGFmdGVyIGxpbmstc3RhdHVzIGlzIEJBRCBhbmQgYWZ0ZXIgYW5ldyBtb2Rlc2V0 IGlzIHRyaWdnZXJlZCBieQo+ID4gPiA+ID4gPiB1c2Vyc3BhY2UuIFdpdGhvdXQgdGhpcyBwYXRj aCwgc2luY2UgaW50ZWxfZHBfbG9uZ19wdWxzZSBnZXRzIGNhbGxlZAo+ID4gPiA+ID4gPiBpdCBy ZXNldHMgdGhlIGxpbmsgZmFpbHVyZSB2YWx1ZXMgYW5kIGxpbmsgcmV0cmFpbmluZyBkb2VzIG5v dCBoYXBwZW4KPiA+ID4gPiA+ID4gYXQgbG93ZXIgbGluayByYXRlcy4KPiA+ID4gPiA+IAo+ID4g PiA+ID4gV2h5IGFyZSB5b3UgcmVzZXR0aW5nIHRoZSBmYWlsdXJlIHZhbHVlcyBpbiB0aGlzIGZ1 bmN0aW9uPyBZb3Ugc2hvdWxkCj4gPiA+ID4gPiBvbmx5IGRvIHRoYXQgd2hlbiBhIGxvbmcgcHVs c2UgaXMgYWN0dWFsbHkgZGV0ZWN0ZWQgSU1PIChhbmQgeWVzLCAKPiA+ID4gPiA+IGNhbGxpbmcg dGhlIGZ1bmN0aW9uIGludGVsX2RwX2xvbmdfcHVsc2UoKSBuYW1lIGlzIHByZXR0eSBtdWNoIHdy b25nCj4gPiA+ID4gPiBub3cpLgo+ID4gPiA+ID4KPiA+ID4gPiAKPiA+ID4gPiBZZXMgdGhlIHZh bHVlcyBmb3IgbGluayByYXRlIG5kIGxhbmUgY291bnQgZ2V0IHNldCB0byB0aGUgaW50ZWxfZHBf bWF4X2xpbmtfYncoKQo+ID4gPiA+IGFuZCBkcm1fZHBfbWF4X2xhbmVfY291bnQoKSBpbiBpbnRl bF9kcF9sb25nX3B1bHNlKCkgYXNzdW1pbmcgdGhhdCB0aGlzIGZ1bmN0aW9uIHdvdWxkCj4gPiA+ ID4gZ2V0IGNhbGxlZCBvbiBob3RwbHVnIGFuZCB0aGF0IHdlIG5lZWQgcmVyZWFkIHRoZSBkcGNk IHJlZ2lzdGVycy4gU28gc2V0dGluZyB0aGVzZSB0byBtYXggdmFsdWVzCj4gPiA+ID4gbWVhbiB0 aGF0IHdlIGhhdmUgbG9zdCB0aGUgaW5mb3JtYXRpb24gYWJvdXQgdGhlIGxpbmsgcmF0ZSBhbmQg bGFuZSBjb3VudCBhdCB3aGljaCBsaW5rIHRyYWluaW5nIGZhaWxlZC4KPiA+ID4gPiAKPiA+ID4g PiBJZiBkZXRlY3RfZG9uZSBpcyByZXNldCBpbiBpbnRlbF9kcF9kZXRlY3QoKSByaWdodCBhZnRl ciBjYWxsaW5nIGludGVsX2RwX2xvbmdfcHVsc2UoKSB3aGljaCBpcyBjbGVhcmx5IGEgYnVnCj4g PiA+ID4gdGhlbiBpdCBjYWxscyB0aGUgaW50ZWxfZHBfbG9uZ19wdWxzZSgpIGR1cmluZyBtb2Rl IGVudW1lcmF0aW9uIGJlZm9yZSB0aGUgbW9kZXNldCBhbmQgaXQgbmV2ZXIgcmV0cmFpbnMgYXQg dGhlIAo+ID4gPiA+IGxvd2VyIHZhbHVlcyBzaW5jZSB0aGUgbWF4IGxpbmsgcmF0ZS9sYW5lIGNv dW50IGdldCBvdmVyd3JpdHRlbiBpbiBpbnRlbF9kcF9sb25nX3B1bHNlKCkuCj4gPiA+ID4gU28g aXQgaXMgYWJzb2x1dGVseSBuZWNlc3NhcnkgdG8gbm90IHJlc2V0IGRldGVjdF9kb25lIGZsYWcg aGVyZSBpbiBpbnRlbF9kcF9kZXRlY3QoKQo+ID4gPiAKPiA+ID4gTm8uIFdoYXQgeW91J3JlIGFz a2luZyBmb3IgaXMgYSBjaGFuZ2UgaW4gYmVoYXZpb3VyICh0byBjYWxsCj4gPiA+IGludGVsX2Rw X2xvbmdfcHVsc2UoKSBmcm9tIC0+ZGV0ZWN0KCkgb25seSBpZiBpdCB3YXMganVzdCBwcmVjZWRl ZCBieSBhbgo+ID4gPiBhY3R1YWwgbG9uZyBwdWxzZSkuIFRoYXQgd2FzIG5ldmVyIGhvdyB0aGlz IGNvZGUgd29ya2VkLiBUaGUgcG9pbnQgb2YKPiA+ID4gdGhlIGZsYWcgd2FzIHRvIGF2b2lkIGNh bGxpbmcgaXQgdHdpY2Ugd2hlbiBwcm9jZXNzaW5nIHRoZSBIUEQgc2luY2UgaXQKPiA+ID4gd2Fz IGRpcmVjdGx5IGNhbGxlZCBmcm9tIGludGVsX2RwX2hwZF9wdWxzZSgpIGFuZCB0aGVuIGFnYWlu IGZyb20KPiA+ID4gLT5kZXRlY3QoKS4gU2luY2Ugd2Ugbm8gbG9uZ2VyIGNhbGwgaXQgZGlyZWN0 bHkgZnJvbQo+ID4gPiBpbnRlbF9kcF9ocGRfcHVsc2UoKSB0aGUgZmxhZyBpcyBpbiBmYWN0IHVz ZWxlc3MuCj4gPiA+Cj4gPiAKPiA+IE5vIEkgdGhpbmsgdGhlcmUgaXMgc29tZSBjb25mdXNpb24u IEkgYW0gbm90IGFza2luZyB0aGUgY2hhbmdlIGluIGJlaGF2aW91ci4gSSBkb250Cj4gPiB3YW50 IHRvIGNhbGwgaW50ZWxfZHBfbG9uZ19wdWxzZSBmcm9tIC0+ZGV0ZWN0KCkgb25seSBpZiBpdCB3 YXMganVzdCBwcmVjZWVkZWQgYnkgYW4gYWN0dWFsIGxvbmcgcHVsc2UuCj4gCj4gVGhhdCBpcyBw cmVjaXNlbHkgd2hhdCB5b3UncmUgYXNraW5nIHNpbmNlIGludGVsX2RwX2hwZF9wdWxzZSgpIHdv dWxkCj4gYmUgdGhlIG9ubHkgcGxhY2UgbGVmdCB0aGF0IHdvdWxkIHJlc2V0IHRoZSBmbGFnLgo+ IAo+ID4gSSB3YW50IHRvIGF2b2lkIGNhbGxpbmcgaXQgdHdpY2UgYW5kIHdoaWNoIGV4YWN0bHkg d2FzIHRoZSBwb2ludCBvZiBhZGRpbmcgdGhhdCBmbGFnLgo+IAo+IFRoZSBjb21taXQgdGhhdCBh ZGRlZCB0aGUgZmxhZyBkaWQgZXhhY3RseSB3aGF0IEkgc3RhdGVkIGFib3ZlLiBJdAo+IGRpZG4n dCBhdm9pZCBhbnkgY2FsbHMgdmlhIG1vZGUgZW51bWVyYXRpb24sIGl0IG9ubHkgYXZvaWQgdGhl IGRvdWJsZQo+IGNhbGwgZHVyaW5nIGFjdHVhbCBocGQgaGFuZGxpbmcuCj4gCj4gV2hpY2ggaXMg YWxzbyBob3cgdGhlIGNvZGUgYmVoYXZlZCBiZWZvcmUgc29tZW9uZSB0cmllZCB0byBtb3ZlIHRo ZQo+IGxvbmcgaHBkIGhhbmRsaW5nIGludG8gdGhlIGhwZCBwdWxzZSBoYW5kbGVyLCBhbmQgaXQn cyBob3cgdGhlIGNvZGUKPiBiZWhhdmVzIG5vdyB0aGF0IEkgbW92ZWQgdGhlIGxvbmcgaHBkIGhh bmRsaW5nIGJhY2sgaW50byAtPmRldGVjdCgpLgo+IAo+ID4gVGhlIGxvbmcgcHVsc2Ugc2hvdWxk Cj4gPiBiZSBjYWxsZWQgb25seSB3aGVuIHRoZSBmdWxsIGRldGVjdCBpcyBub3QgZG9uZSwgd2Ug c2hvdWxkbnQgYmUgZG9pbmcgZnVsbCBkZXRlY3QgdHdpY2UuIEluIGludGVsX2RwX2hwZF9wdWxz ZSgpCj4gPiB3ZSBkbyBzZXQgdGhlIGRldGVjdF9kb25lIGZsYWcgdG8gZmFsc2UgYW5kIGl0IGRv ZXMgYSBmdWxsIGRldGVjdCB0aHJvdWdoIC0+ZGV0ZWN0KCkuIEJ1dCB0aGVuCj4gPiBmb3IgbW9k ZSBlbnVtZXJhdGlvbiwgd2UgZG8gbm90IG5lZWQgdG8gZG8gYSBmdWxsIGRldGVjdCBzbyB0aGF0 IC0+ZGV0ZWN0KCkgY2FsbCBzaG91bGQgYWN0dWFsbHkgbm90Cj4gPiBjYWxsIGludGVsX2RwX2xv bmdfcHVsc2UgYmVjYXVzZSB0aGF0IGlzIGV4YWN0bHkgdGhlIGJlaGF2b3VyIHdlIHdlcmUgdHJ5 aW5nIHRvIGF2b2lkIChjYWxsaW5nIGl0IHR3aWNlKQo+ID4gCj4gPiBNYW5hc2kgCj4gPiA+IFdo aWxlIHRoZSBjaGFuZ2UgeW91IGFzayBmb3IgbWF5IGJlIGRlc2lyYWJsZSwgaGlzdG9yeSBoYXMg c2hvd24KPiA+ID4gdGhhdCB0aGUgRFAgY29kZSBpcyB2ZXJ5IGZyYWdpbGUsIHNvIEkgZG9uJ3Qg dGhpbmsgd2Ugc2hvdWxkIG1ha2UKPiA+ID4gdGhlIGxpbmsgc3RhdGUgcHJvcGVydHkgZGVwZW5k IG9uIHNvbWV0aGluZyB0aGF0IG1heSBuZWVkIHRvIGJlCj4gPiA+IHJldmVydGVkIGlmIGEgcmVn cmVzc2lvbiBjcm9wcyB1cC4gQW5kIHNvIEkgdGhpbmsgeW91IHNob3VsZCBqdXN0Cj4gPiA+IGNo YW5nZSB5b3VyIG5ldyBjb2RlIHRvIHdvcmsgd2l0aCB0aGUgZXhpc3Rpbmcgc2NoZW1lLiBXZSBj YW4gcHVzaAo+ID4gPiB0aGUgZGV0ZWN0X2RvbmUgb3B0aW1pemF0aW9uIGluIGFmdGVyd2FyZHMg c2luY2Ugd2Ugc2hvdWxkIHRoZW4gYmUKPiA+ID4gYWJsZSB0byByZXZlcnQgaXQgd2l0aG91dCBo YXZpbmcgdG8gcmV2ZXJ0IGV2ZXJ5dGhpbmcgcmVsYXRlZCB0bwo+ID4gPiB0aGUgbGluayBzdGF0 dXMgcHJvcGVydHkuCj4gPiA+CgpTbyBjdXJyZW50bHkgaXQgcmVhZHMgYWxsIHRoZSBkcGNkIHZh bHVlcyBvbiBob3RwbHVnIGFuZCB0aGVuIGl0IHJlcmVhZHMgCmV2ZXJ5dGhpbmcgb24gZHJtX2hl bHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzKCkKU28gaW4gY2FzZSBvZiBsaW5rIGZh aWx1cmUgSSBzZXQgdGhlIG1heGxpbmtyYXRlIGFuZCBsYW5lIGNvdW50IHRvIHRoZSB2YWx1ZXMg bG93ZXIKdGhhbiB0aGUgdmFsdWVzIGF0IHdoaWNoIGxpbmsgdHJhaW5pbmcgZmFpbGVkLCBidXQg d2hlbiB1c2Vyc3BhY2UgdHJpZXMgdG8gcmVkbyBhIG1vZGVzZXQsCml0IGNhbGxzIGRybV9oZWxw ZXJfcHJvYmVfc2luZ2xlX2Nvbm5lY3Rvcl9tb2RlcygpIGFuZCBjYWxscyBkZXRlY3QoKSB3aGlj aCBjYWxscyBsb25nX3B1bHNlCmFuZCByZXdyaXRlcyB0aGUgbWF4IGxpbmsgcmF0ZSBhbmQgbGFu ZSBjb3VudCBhbmQgc28gaW5zdGVhZCBvZiB0cmFpbmluZyBhdCBsb3dlciB2YWx1ZXMgaXQKdHJh aW5zIGFnYWluIGF0IHRoZSBzYW1lIHZhbHVlcyAuClNvIHRoZSBvdGhlciBhbHRlcm5hdGl2ZSBp cyBzcGxpdHRpbmcgdGhlIGludGVsX2RwX2xvbmdfcHVsc2UoKSBhbmQgZG8gcGFydHMgb2YgaXQg bGlrZQpyZWFkIHRoZSBkcGNkIHJlZ2lzdGVycyBpLmUgY2FsbCBpbnRlbF9kcF9kZXRlY3RfZHBj ZCgpIGFuZCBzZXQgdGhlIG1heCBsaW5rIHJhdGUgYW5kCm1heCBsYW5lIGNvdW50IGluIGludGVs X2RwX2hwZF9wdWxzZSgpLiBUaGF0IHdheSB3ZSBzZXQgdGhlIG1heCB2YWx1ZXMgb25seSBvbmNl IGF0CmhvdHBsdWcgYW5kIGF2b2lkIHRoZW0gZ2V0dGluZyByZXdyaXR0ZW4gZHVyaW5nIG1vZGUg ZW51bWVyYXRpb24uCgpBbnkgdGhvdWdodHMgVmlsbGUvSmFuaS9EYW5pZWw/CgpNYW5hc2kKPiA+ ID4gPiAKPiA+ID4gPiBNYW5hc2kgCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBWaWxsZS9KYW5p IGNvdWxkIHlvdSBwbGVhc2UgcmV2aWV3IHRoaXMgcGF0Y2g/Cj4gPiA+ID4gPiA+IFRoaSBpcyBk ZWZpbml0ZWx5IGEgYnVnIGluIHRoZSBleGlzdGluZyBjb2RlYmFzZSBhbmQgd2UgbmVlZCB0byBn ZXQgdGhpcyBtZXJnZWQKPiA+ID4gPiA+ID4gc29vbiB0byBnZXQgaXQgZml4ZWQuCj4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiBSZWdhcmRzCj4gPiA+ID4gPiA+IE1hbmFzaQo+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gT24gVGh1LCBEZWMgMjksIDIwMTYgYXQgMTE6MTQ6MjhQTSAtMDgwMCwgRGhp bmFrYXJhbiBQYW5kaXlhbiB3cm90ZToKPiA+ID4gPiA+ID4gPiBGcm9tOiAiTmF2YXJlLCBNYW5h c2kgRCIgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4g PiA+ID4gVGhlIGRldGVjdF9kb25lIGZsYWcgd2FzIGludHJvZHVjZWQgaW4gdGhlICdjb21taXQg N2QyM2UzYzM3YmIzCj4gPiA+ID4gPiA+ID4gKCJkcm0vaTkxNTogQ2xlYW5pbmcgdXAgaW50ZWxf ZHBfaHBkX3B1bHNlIiknIGluIG9yZGVyIHRvIGF2b2lkIG11bHRpcGxlCj4gPiA+ID4gPiA+ID4g ZGV0ZWN0cyBvbiBob3RwbHVnIHdoZXJlIGludGVsX2RwX2xvbmdfcHVsc2UoKSB3YXMgY2FsbGVk IGZyb20gSFBEIGhhbmRsZXIKPiA+ID4gPiA+ID4gPiBhcyB3ZWxsIGFzIGludGVsX2RwX2RldGVj dCgpLiBMYXRlciwgJ2NvbW1pdCAxMDE1ODExNjA5YzAKPiA+ID4gPiA+ID4gPiAoImRybS9pOTE1 OiBNb3ZlIGxvbmcgaHBkIGhhbmRsaW5nIGludG8gdGhlIGhvdHBsdWcgd29yayIpJyBkZWZlcnJl ZCBsb25nCj4gPiA+ID4gPiA+ID4gaHBkIGhhbmRsaW5nIHRvIGhvdHBsdWcgd29yayB0byBhdm9p ZCBoYW5kbGluZyBpdCB0d2ljZS4gQnV0LCByZXNldHRpbmcgdGhlCj4gPiA+ID4gPiA+ID4gZmxh ZyBhZnRlciBsb25nIGhwZCBoYW5kbGluZyBsZWFkcyB0byB0aGUgY29kZSBiZWluZyBleGVjdXRl ZCBhZ2FpbiBkdXJpbmcKPiA+ID4gPiA+ID4gPiBtb2RlIGVudW1lcmF0aW9uLgo+ID4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiA+IFNvLCBkbyBub3QgcmVzZXQgdGhlIGRldGVjdF9kb25lIGZsYWcg dG8gRmFsc2UgaW4gaW50ZWxfZHBfZGV0ZWN0KCkuIFRoZQo+ID4gPiA+ID4gPiA+IGZsYWcgaXMg cmVzZXQgaW4gaW50ZWxfZHBfaHBkX3B1bHNlKCkgdG8gYWxsb3cgYSBmdWxsIGRldGVjdCBhbmQg c2V0IHdoZW4KPiA+ID4gPiA+ID4gPiB0aGUgaG90cGx1ZyB3b3JrIGRvZXMgYSBmdWxsIERQQ0Qg ZGV0ZWN0LiBIb3dldmVyIGlmIC0+ZGV0ZWN0KCkgZ2V0cyBjYWxsZWQKPiA+ID4gPiA+ID4gPiBk dXJpbmcgbW9kZSBlbnVtZXJhdGlvbiBhZnRlciBhIERQQ0QgZGV0ZWN0LCByZXR1cm4gdGhlIGNh Y2hlZCBjb25uZWN0b3IKPiA+ID4gPiA+ID4gPiBzdGF0dXMuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+ID4gUmVzZXR0aW5nIHRoZSBmbGFnIGluIHRoZSBlbmNvZGVyJ3MgcmVzZXQgY2FsbGJh Y2sgc2hvdWxkIHRha2UgY2FyZSBvZgo+ID4gPiA+ID4gPiA+IGhvdHBsdWcgYmV0d2VlbiBzdXNw ZW5kL3Jlc3VtZS4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiB2MjoKPiA+ID4gPiA+ID4g PiBBbGxvdyBmdWxsIGRldGVjdCBhZnRlciBlbmNvZGVyIHJlc2V0LiAoVmlsbGUpCj4gPiA+ID4g PiA+ID4gU2V0IHRoZSBkZXRlY3RfZG9uZSBmbGFnIGZvciBjb25uZWN0b3IgZGlzY29ubmVjdGVk IGNhc2UgdG9vLiAoREspCj4gPiA+ID4gPiA+ID4gQ29tbWl0IG1lc3NhZ2UgY2hhbmdlcy4KPiA+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4g PiA+ID4gPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+ID4gPiA+ID4gPiBDYzogQW5kZXIgQ29uc2VsdmFuZGUgT2xpdmVpcmEgPGFuZGVyLmNv bnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gQ2M6IEphbmkgTmlr dWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gRml4ZXM6IGNv bW1pdCA3ZDIzZTNjMzdiYjMgKCJkcm0vaTkxNTogQ2xlYW5pbmcgdXAgaW50ZWxfZHBfaHBkX3B1 bHNlIikKPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2ku ZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2Fy YW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+ IC0tLQo+ID4gPiA+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgOSAr KysrKy0tLS0KPiA+ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPiA+ID4gPiA+ID4gPiBpbmRleCBmYjEyODk2Li42NzMyYzE3IDEwMDY0NAo+ID4g PiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gPiA+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ID4gPiA+ID4g QEAgLTQ1MTYsNyArNDUxNiw2IEBAIGludGVsX2RwX2xvbmdfcHVsc2Uoc3RydWN0IGludGVsX2Nv bm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ID4gPiA+ID4gPiA+ICAJaW50ZWxfZHBfc2V0X2Vk aWQoaW50ZWxfZHApOwo+ID4gPiA+ID4gPiA+ICAJaWYgKGlzX2VkcChpbnRlbF9kcCkgfHwgaW50 ZWxfY29ubmVjdG9yLT5kZXRlY3RfZWRpZCkKPiA+ID4gPiA+ID4gPiAgCQlzdGF0dXMgPSBjb25u ZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiA+ID4gPiA+ID4gPiAtCWludGVsX2RwLT5kZXRlY3Rf ZG9uZSA9IHRydWU7Cj4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICAJLyogVHJ5IHRvIHJl YWQgdGhlIHNvdXJjZSBvZiB0aGUgaW50ZXJydXB0ICovCj4gPiA+ID4gPiA+ID4gIAlpZiAoaW50 ZWxfZHAtPmRwY2RbRFBfRFBDRF9SRVZdID49IDB4MTEgJiYKPiA+ID4gPiA+ID4gPiBAQCAtNDU1 MSwxMCArNDU1MCwxMCBAQCBpbnRlbF9kcF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3RvciwgYm9vbCBmb3JjZSkKPiA+ID4gPiA+ID4gPiAgCQkgICAgICBjb25uZWN0b3ItPmJh c2UuaWQsIGNvbm5lY3Rvci0+bmFtZSk7Cj4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICAJ LyogSWYgZnVsbCBkZXRlY3QgaXMgbm90IHBlcmZvcm1lZCB5ZXQsIGRvIGEgZnVsbCBkZXRlY3Qg Ki8KPiA+ID4gPiA+ID4gPiAtCWlmICghaW50ZWxfZHAtPmRldGVjdF9kb25lKQo+ID4gPiA+ID4g PiA+ICsJaWYgKCFpbnRlbF9kcC0+ZGV0ZWN0X2RvbmUpIHsKPiA+ID4gPiA+ID4gPiArCQlpbnRl bF9kcC0+ZGV0ZWN0X2RvbmUgPSB0cnVlOwo+ID4gPiA+ID4gPiA+ICAJCXN0YXR1cyA9IGludGVs X2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gPiA+ID4gPiA+ ID4gLQo+ID4gPiA+ID4gPiA+IC0JaW50ZWxfZHAtPmRldGVjdF9kb25lID0gZmFsc2U7Cj4gPiA+ ID4gPiA+ID4gKwl9Cj4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICAJcmV0dXJuIHN0YXR1 czsKPiA+ID4gPiA+ID4gIH0KPiA+ID4gPiA+ID4gPiBAQCAtNDg1OSw2ICs0ODU4LDggQEAgdm9p ZCBpbnRlbF9kcF9lbmNvZGVyX3Jlc2V0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiA+ ID4gPiA+ID4gPiAgCWlmIChsc3Bjb24tPmFjdGl2ZSkKPiA+ID4gPiA+ID4gPiAgCQlsc3Bjb25f cmVzdW1lKGxzcGNvbik7Cj4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICsJaW50ZWxfZHAt PmRldGVjdF9kb25lID0gZmFsc2U7Cj4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ICAJcHBz X2xvY2soaW50ZWxfZHApOwo+ID4gPiA+ID4gPiA+ICAKPiA+ID4gPiA+ID4gPiAgCWlmIChJU19W QUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+ID4gPiA+ ID4gPiAtLSAKPiA+ID4gPiA+ID4gPiAyLjcuNAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gCj4g PiA+ID4gPiAtLSAKPiA+ID4gPiA+IFZpbGxlIFN5cmrDpGzDpAo+ID4gPiA+ID4gSW50ZWwgT1RD Cj4gPiA+IAo+ID4gPiAtLSAKPiA+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiA+IEludGVsIE9UQwo+ IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:63376 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461AbdASUkg (ORCPT ); Thu, 19 Jan 2017 15:40:36 -0500 Date: Thu, 19 Jan 2017 12:39:14 -0800 From: Manasi Navare To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , jani.nikula@linux.intel.com, daniel.vetter@ffwll.ch Cc: jani.nikula@linux.intel.com, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Ander Conselvande Oliveira Subject: Re: [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect Message-ID: <20170119203914.GB30684@intel.com> References: <1483082068-5833-1-git-send-email-dhinakaran.pandiyan@intel.com> <20170117174041.GB15796@intel.com> <20170119134234.GY31595@intel.com> <20170119190101.GA30494@intel.com> <20170119192636.GZ31595@intel.com> <20170119193855.GA30684@intel.com> <20170119195954.GB31595@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170119195954.GB31595@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jan 19, 2017 at 09:59:54PM +0200, Ville Syrj�l� wrote: > On Thu, Jan 19, 2017 at 11:38:56AM -0800, Manasi Navare wrote: > > On Thu, Jan 19, 2017 at 09:26:36PM +0200, Ville Syrj�l� wrote: > > > On Thu, Jan 19, 2017 at 11:01:01AM -0800, Manasi Navare wrote: > > > > On Thu, Jan 19, 2017 at 03:42:34PM +0200, Ville Syrj�l� wrote: > > > > > On Tue, Jan 17, 2017 at 09:40:42AM -0800, Manasi Navare wrote: > > > > > > I have verified this patch with the latest drm-tip and it is also > > > > > > absolutely necessary to ensure the link gets properly retrained > > > > > > after link-status is BAD and after anew modeset is triggered by > > > > > > userspace. Without this patch, since intel_dp_long_pulse gets called > > > > > > it resets the link failure values and link retraining does not happen > > > > > > at lower link rates. > > > > > > > > > > Why are you resetting the failure values in this function? You should > > > > > only do that when a long pulse is actually detected IMO (and yes, > > > > > calling the function intel_dp_long_pulse() name is pretty much wrong > > > > > now). > > > > > > > > > > > > > Yes the values for link rate nd lane count get set to the intel_dp_max_link_bw() > > > > and drm_dp_max_lane_count() in intel_dp_long_pulse() assuming that this function would > > > > get called on hotplug and that we need reread the dpcd registers. So setting these to max values > > > > mean that we have lost the information about the link rate and lane count at which link training failed. > > > > > > > > If detect_done is reset in intel_dp_detect() right after calling intel_dp_long_pulse() which is clearly a bug > > > > then it calls the intel_dp_long_pulse() during mode enumeration before the modeset and it never retrains at the > > > > lower values since the max link rate/lane count get overwritten in intel_dp_long_pulse(). > > > > So it is absolutely necessary to not reset detect_done flag here in intel_dp_detect() > > > > > > No. What you're asking for is a change in behaviour (to call > > > intel_dp_long_pulse() from ->detect() only if it was just preceded by an > > > actual long pulse). That was never how this code worked. The point of > > > the flag was to avoid calling it twice when processing the HPD since it > > > was directly called from intel_dp_hpd_pulse() and then again from > > > ->detect(). Since we no longer call it directly from > > > intel_dp_hpd_pulse() the flag is in fact useless. > > > > > > > No I think there is some confusion. I am not asking the change in behaviour. I dont > > want to call intel_dp_long_pulse from ->detect() only if it was just preceeded by an actual long pulse. > > That is precisely what you're asking since intel_dp_hpd_pulse() would > be the only place left that would reset the flag. > > > I want to avoid calling it twice and which exactly was the point of adding that flag. > > The commit that added the flag did exactly what I stated above. It > didn't avoid any calls via mode enumeration, it only avoid the double > call during actual hpd handling. > > Which is also how the code behaved before someone tried to move the > long hpd handling into the hpd pulse handler, and it's how the code > behaves now that I moved the long hpd handling back into ->detect(). > > > The long pulse should > > be called only when the full detect is not done, we shouldnt be doing full detect twice. In intel_dp_hpd_pulse() > > we do set the detect_done flag to false and it does a full detect through ->detect(). But then > > for mode enumeration, we do not need to do a full detect so that ->detect() call should actually not > > call intel_dp_long_pulse because that is exactly the behavour we were trying to avoid (calling it twice) > > > > Manasi > > > While the change you ask for may be desirable, history has shown > > > that the DP code is very fragile, so I don't think we should make > > > the link state property depend on something that may need to be > > > reverted if a regression crops up. And so I think you should just > > > change your new code to work with the existing scheme. We can push > > > the detect_done optimization in afterwards since we should then be > > > able to revert it without having to revert everything related to > > > the link status property. > > > So currently it reads all the dpcd values on hotplug and then it rereads everything on drm_helper_probe_single_connector_modes() So in case of link failure I set the maxlinkrate and lane count to the values lower than the values at which link training failed, but when userspace tries to redo a modeset, it calls drm_helper_probe_single_connector_modes() and calls detect() which calls long_pulse and rewrites the max link rate and lane count and so instead of training at lower values it trains again at the same values . So the other alternative is splitting the intel_dp_long_pulse() and do parts of it like read the dpcd registers i.e call intel_dp_detect_dpcd() and set the max link rate and max lane count in intel_dp_hpd_pulse(). That way we set the max values only once at hotplug and avoid them getting rewritten during mode enumeration. Any thoughts Ville/Jani/Daniel? Manasi > > > > > > > > Manasi > > > > > > > > > > > > Ville/Jani could you please review this patch? > > > > > > Thi is definitely a bug in the existing codebase and we need to get this merged > > > > > > soon to get it fixed. > > > > > > > > > > > > Regards > > > > > > Manasi > > > > > > > > > > > > On Thu, Dec 29, 2016 at 11:14:28PM -0800, Dhinakaran Pandiyan wrote: > > > > > > > From: "Navare, Manasi D" > > > > > > > > > > > > > > The detect_done flag was introduced in the 'commit 7d23e3c37bb3 > > > > > > > ("drm/i915: Cleaning up intel_dp_hpd_pulse")' in order to avoid multiple > > > > > > > detects on hotplug where intel_dp_long_pulse() was called from HPD handler > > > > > > > as well as intel_dp_detect(). Later, 'commit 1015811609c0 > > > > > > > ("drm/i915: Move long hpd handling into the hotplug work")' deferred long > > > > > > > hpd handling to hotplug work to avoid handling it twice. But, resetting the > > > > > > > flag after long hpd handling leads to the code being executed again during > > > > > > > mode enumeration. > > > > > > > > > > > > > > So, do not reset the detect_done flag to False in intel_dp_detect(). The > > > > > > > flag is reset in intel_dp_hpd_pulse() to allow a full detect and set when > > > > > > > the hotplug work does a full DPCD detect. However if ->detect() gets called > > > > > > > during mode enumeration after a DPCD detect, return the cached connector > > > > > > > status. > > > > > > > > > > > > > > Resetting the flag in the encoder's reset callback should take care of > > > > > > > hotplug between suspend/resume. > > > > > > > > > > > > > > v2: > > > > > > > Allow full detect after encoder reset. (Ville) > > > > > > > Set the detect_done flag for connector disconnected case too. (DK) > > > > > > > Commit message changes. > > > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > Cc: Ville Syrjala > > > > > > > Cc: Ander Conselvande Oliveira > > > > > > > Cc: Jani Nikula > > > > > > > Fixes: commit 7d23e3c37bb3 ("drm/i915: Cleaning up intel_dp_hpd_pulse") > > > > > > > Signed-off-by: Manasi Navare > > > > > > > Signed-off-by: Dhinakaran Pandiyan > > > > > > > --- > > > > > > > drivers/gpu/drm/i915/intel_dp.c | 9 +++++---- > > > > > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > > > > > > index fb12896..6732c17 100644 > > > > > > > --- a/drivers/gpu/drm/i915/intel_dp.c > > > > > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > > > > > > @@ -4516,7 +4516,6 @@ intel_dp_long_pulse(struct intel_connector *intel_connector) > > > > > > > intel_dp_set_edid(intel_dp); > > > > > > > if (is_edp(intel_dp) || intel_connector->detect_edid) > > > > > > > status = connector_status_connected; > > > > > > > - intel_dp->detect_done = true; > > > > > > > > > > > > > > /* Try to read the source of the interrupt */ > > > > > > > if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 && > > > > > > > @@ -4551,10 +4550,10 @@ intel_dp_detect(struct drm_connector *connector, bool force) > > > > > > > connector->base.id, connector->name); > > > > > > > > > > > > > > /* If full detect is not performed yet, do a full detect */ > > > > > > > - if (!intel_dp->detect_done) > > > > > > > + if (!intel_dp->detect_done) { > > > > > > > + intel_dp->detect_done = true; > > > > > > > status = intel_dp_long_pulse(intel_dp->attached_connector); > > > > > > > - > > > > > > > - intel_dp->detect_done = false; > > > > > > > + } > > > > > > > > > > > > > > return status; > > > > > > } > > > > > > > @@ -4859,6 +4858,8 @@ void intel_dp_encoder_reset(struct drm_encoder *encoder) > > > > > > > if (lspcon->active) > > > > > > > lspcon_resume(lspcon); > > > > > > > > > > > > > > + intel_dp->detect_done = false; > > > > > > > + > > > > > > > pps_lock(intel_dp); > > > > > > > > > > > > > > if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) > > > > > > > -- > > > > > > > 2.7.4 > > > > > > > > > > > > > > > > > -- > > > > > Ville Syrj�l� > > > > > Intel OTC > > > > > > -- > > > Ville Syrj�l� > > > Intel OTC > > -- > Ville Syrj�l� > Intel OTC