From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: Paul.Durrant@citrix.com, konrad.wilk@oracle.com,
wei.liu2@citrix.com, netdev@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] xennet_start_xmit assumptions
Date: Thu, 19 Jan 2017 17:41:23 -0500 [thread overview]
Message-ID: <20170119224123.GB19618@oracle.com> (raw)
In-Reply-To: <20170119184733.GJ22018@oracle.com>
On (01/19/17 13:47), Sowmini Varadhan wrote:
> > Specifically I'm talking about the dev_validate_header() check.
> > That is supposed to protect us from these kinds of situations.
>
> ah, but I run my pf_packet application as root, so I have
> capable(CAP_SYS_RAWIO), so I slip through the dev_validate_header()
> check.
and in that light, should dev_validate_header()
always return false if len == 0?
that will take care of all the send paths in af_packet.c
but it impacts all drivers as well (even though it is the
logically correct thing to do..)
--Sowmini
next prev parent reply other threads:[~2017-01-19 22:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 15:31 xennet_start_xmit assumptions Sowmini Varadhan
2017-01-18 19:25 ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-01-19 9:36 ` Paul Durrant
2017-01-19 11:14 ` Sowmini Varadhan
2017-01-19 11:14 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 11:31 ` Paul Durrant
2017-01-19 11:37 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 11:37 ` Sowmini Varadhan
2017-01-19 16:37 ` David Miller
2017-01-19 18:47 ` Sowmini Varadhan
2017-01-19 22:41 ` Sowmini Varadhan [this message]
2017-01-20 19:30 ` David Miller
2017-01-20 19:30 ` [Xen-devel] " David Miller
2017-01-20 20:03 ` Sowmini Varadhan
2017-01-20 20:03 ` Sowmini Varadhan
2017-01-19 22:41 ` Sowmini Varadhan
2017-01-25 15:06 ` Paul Durrant
2017-01-25 15:06 ` [Xen-devel] " Paul Durrant
2017-01-25 15:45 ` Sowmini Varadhan
2017-01-25 15:45 ` Sowmini Varadhan
2017-01-18 19:25 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119224123.GB19618@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=Paul.Durrant@citrix.com \
--cc=davem@davemloft.net \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.