From: Greg KH <gregkh@linuxfoundation.org>
To: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: alexander.levin@verizon.com,
Thomas Deutschmann <whissi@gentoo.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"jesse@kernel.org" <jesse@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [E] Re: Patch "tunnels: Don't apply GRO to multiple layers of encapsulation" (CVE-2016-8666) is missing in 4.1 and 3.18 stable tree
Date: Fri, 20 Jan 2017 09:28:13 +0100 [thread overview]
Message-ID: <20170120082813.GA28701@kroah.com> (raw)
In-Reply-To: <CAKPo+=esbKa7mwgKjo6+sDy+qtQ-GOdx_g_RkP5DqPj5U5cKPQ@mail.gmail.com>
On Fri, Jan 20, 2017 at 08:14:23AM +0900, Seung-Woo Kim wrote:
> Hi,
>
> On Fri, Jan 13, 2017 at 2:51 AM, <alexander.levin@verizon.com> wrote:
> > On Tue, Jan 10, 2017 at 07:45:48AM +0100, Greg KH wrote:
> >> On Tue, Jan 10, 2017 at 03:09:28AM +0100, Thomas Deutschmann wrote:
> >> > Hi,
> >> >
> >> > the following patch was backported to the following LTS kernels
> >> >
> >> > - >=4.4.29
> >> > - >=3.16.35
> >> >
> >> >
> >> > however it is missing from LTS kernels
> >> >
> >> > - linux-4.1
> >> > - linux-3.18
> >>
> >> 3.18 is (or should be), end-of-life now (Sasha, can we just kill it?
> >> Please?)
> >>
> >> 4.1 is a bit slower release cycle, and again, Sasha will speak to that.
> >
> > I'll add commit to both, and will do final release for 3.18 in a couple of days.
>
> The commit is applied linux-4.1.y and linux-3.18.y, but it causes
> build warning about unused function sit_gro_receive.
>
> It seems that the following part of mainline commit is missed.
>
> static int ipv6_gro_complete(struct sk_buff *skb, int nhoff)
> {
> const struct net_offload *ops;
> @@ -302,7 +315,7 @@ static struct packet_offload ipv6_packet
> static const struct net_offload sit_offload = {
> .callbacks = {
> .gso_segment = ipv6_gso_segment,
> - .gro_receive = ipv6_gro_receive,
> + .gro_receive = sit_gro_receive,
> .gro_complete = sit_gro_complete,
> },
> };
Ah, nice catch.
Sasha, want to add this to the trees and do another release? Or I can
do it if you don't want to, for 3.18.y
thanks,
greg k-h
prev parent reply other threads:[~2017-01-20 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 2:09 Patch "tunnels: Don't apply GRO to multiple layers of encapsulation" (CVE-2016-8666) is missing in 4.1 and 3.18 stable tree Thomas Deutschmann
2017-01-10 6:45 ` Greg KH
[not found] ` <20170112170836.5dzdxjfcrbx6en3c@sasha-lappy>
2017-01-19 23:14 ` [E] " Seung-Woo Kim
2017-01-20 8:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120082813.GA28701@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.levin@verizon.com \
--cc=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=whissi@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.