From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] configs/altera_sockit: bump kernel to 4.7 and u-boot to v2016.11-rc3
Date: Fri, 20 Jan 2017 14:15:13 +1100 [thread overview]
Message-ID: <20170120141513.34e1010e@free-electrons.com> (raw)
In-Reply-To: <1484839933-17637-2-git-send-email-lucas.bajolet@savoirfairelinux.com>
Hello,
On Thu, 19 Jan 2017 10:32:10 -0500, Lucas Bajolet wrote:
> BR2_TARGET_UBOOT=y
> -BR2_TARGET_UBOOT_BOARDNAME="socfpga_cyclone5"
> +BR2_TARGET_UBOOT_BOARDNAME="socfpga_sockit"
> BR2_TARGET_UBOOT_CUSTOM_GIT=y
> -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="http://git.rocketboards.org/u-boot-socfpga.git"
> -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_acds13.0sp1"
> BR2_TARGET_UBOOT_PATCH="board/altera/sockit"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/altera-opensource/u-boot-socfpga"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.11-rc3"
Why do you bump to a -rc version rather than a final stable version?
Also, you only remove the existing U-Boot patch in PATCH 2/4. Which
means if I apply only PATCH 1/4, the build is broken.
Patch series should be bisectable: applying PATCH 1/4 only should work,
applying PATCH 1/4 and 2/4 only should work, applying PATCH 1/4, 2/4
and 3/4 only should work.
Could you rework your series with this in mind?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-20 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 15:32 [Buildroot] [PATCH 0/4] Altera SoCkit board support fixes Lucas Bajolet
2017-01-19 15:32 ` [Buildroot] [PATCH 1/4] configs/altera_sockit: bump kernel to 4.7 and u-boot to v2016.11-rc3 Lucas Bajolet
2017-01-19 16:11 ` Sebastien Bourdelin
2017-01-20 3:15 ` Thomas Petazzoni [this message]
2017-01-20 15:45 ` Peter Korsgaard
2017-01-19 15:32 ` [Buildroot] [PATCH 2/4] board/altera: changed path contents to support sockit from official config Lucas Bajolet
2017-01-19 16:13 ` Sebastien Bourdelin
2017-01-19 15:32 ` [Buildroot] [PATCH 3/4] board/altera: update patch to support new official SoCkit Lucas Bajolet
2017-01-19 17:00 ` Sebastien Bourdelin
2017-01-19 19:12 ` Lucas Bajolet
2017-01-19 15:32 ` [Buildroot] [PATCH 4/4] board/altera: update README for new scripts and fixed some typos Lucas Bajolet
2017-01-19 17:05 ` Sebastien Bourdelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120141513.34e1010e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.